Fix for un-mocked calls. #44

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@ezarko
ezarko commented Dec 5, 2011

I was having an issue where I was trying to mock a somewhat long call which required access to the Internet (so that I could iterate faster and without necessarily having connectivity). There were certain calls, however, that I did not want to mock because they were only hitting my local development instance. They didn't seem to be working properly though. After some debugging this seems to be the answer to the problem. If it is acceptable to you please merge.

ezarko added some commits Dec 5, 2011
@ezarko ezarko lint fabfdb8
@ezarko ezarko Fixed un-mocked requests.
The original arguments are url and origSettings.  At the beginning of
the function if url is an object, origSettings is set to url and url is
set to undefined.  In Google Chrome on Mac (at least) this means that
arguments ends up being length 1 with just undefined in it.
1a9b7c2
@zymsys
zymsys commented on 1a9b7c2 Dec 30, 2011

Thanks ezarko - I'm adding unit tests to some existing code and working through ajax requests one at a time with mocks. This really helped me out.

Contributor
mlynch commented Mar 21, 2012

Looks like this was fixed with #48 as well. This can be closed.

@jdsharp jdsharp closed this Mar 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment