Fixed the jsonp callback context error. #67

merged 1 commit into from Apr 10, 2013


None yet
6 participants

davehamptonusa commented May 25, 2012

It was just a few undeclared variables. It's done poorly. Perhaps the callbackContext should be part of an object and made available via that... or perhaps more global so all the functions can access it....

I just passed the callbackContext around. I like this approach less than putting it all in an object, but more than a more global closure variable...

To each their own...


mattmcla commented May 29, 2012

Hey dave, I have a pull request in that potentially fixes this same issue


or maybe there's more than one error ;)


jcreamer898 commented Jul 26, 2012

@davehamptonusa Can you verify if 18f947b fixes the issue you are referring to?


can3p commented Aug 23, 2012

These pull requests fix different things. callbackContext is not passed to the functions jsonpSuccess and jsonpComplete, and it's not fixed in the request of @mattmcla . This pull request fixes this.

@dcneiner dcneiner merged commit d7492a2 into jakerella:master Apr 10, 2013


dcneiner commented Apr 10, 2013

@davehamptonusa Thank you for your work on this… sorry its taken so long to merge this in :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment