Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DebugTree to be subclassed #54

Closed
NachoSoto opened this issue Apr 14, 2015 · 0 comments · Fixed by #56
Closed

Allow DebugTree to be subclassed #54

NachoSoto opened this issue Apr 14, 2015 · 0 comments · Fixed by #56

Comments

@NachoSoto
Copy link

I might be missing something, but I can't find a way to implement a CrashReportingTree like in the example that implements TaggedTree instead of Tree.

As a consequence of this, logs sent to Crashlytics don't have the context of the tag associated to them, which make them pretty useless.

It would be great if the tagging functionality implemented in DebugTree was abstracted out so that other subclasses could reuse it, or if the implementation of the Tree methods weren't marked as final so that they could be overridden to forward logs to Crashlytics instead (or anything else).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant