Bugfix update connect vraserver function #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging in latest changes from Master.
martin9700
reviewed
Jul 23, 2020
| if ($_.Exception.Response.StatusCode -eq "BadRequest") { | ||
| # This could be due to an incorrectly set UserAttribute, so customizing the message. | ||
| if ($Username -match "@") { | ||
| Write-Host -ForegroundColor White -BackgroundColor DarkGray "Unfortunately, you have received a 400 BAD Request Error. Is it possible that your environment has userPrincipalName set as the Username attribute? If so, please make sure to include the parameter UserAttribute and set it to either UPN or userPrincipalName (e.g. -UserAttribute UPN)" |
There was a problem hiding this comment.
This should all be part of the throw message, or (my preference) Write-Error with an -ErrorAction Stop. By using Write-Host it's now impossible for an upstream script to capture the error.
There was a problem hiding this comment.
Good note, update incoming.
There was a problem hiding this comment.
updated here: new commit
martin9700
reviewed
Jul 23, 2020
| if ($Username -match "@") { | ||
| Write-Host -ForegroundColor White -BackgroundColor DarkGray "Unfortunately, you have received a 400 BAD Request Error. Is it possible that your environment has userPrincipalName set as the Username attribute? If so, please make sure to include the parameter UserAttribute and set it to either UPN or userPrincipalName (e.g. -UserAttribute UPN)" | ||
| } else { | ||
| Write-Host -ForegroundColor White -BackgroundColor DarkGray "Unfortunately, you have received a 400 BAD Request Error. It is possible that the Username you provided, $Username, is missing a domain (e.g. $Username@domain.com)?" |
There was a problem hiding this comment.
Make this the Throw message (or Write-Error).
There was a problem hiding this comment.
good note, update incoming.
There was a problem hiding this comment.
updated here: new commit
martin9700
approved these changes
Jul 23, 2020
jonathanmedd
requested changes
Jul 24, 2020
| @@ -12,6 +12,7 @@ | |||
| .PARAMETER Username | |||
| Username to connect with | |||
| For domain accounts ensure to specify the Username in the format username@domain, not Domain\Username | |||
| Note: UPN's are valid login Usernames as well and may also be in the format username@domain | |||
There was a problem hiding this comment.
Suggested change
| Note: UPN's are valid login Usernames as well and may also be in the format username@domain | |
| Note: UPNs are valid login Usernames as well and may also be in the format username@domain |
There was a problem hiding this comment.
Just submitted the fix for this typo in latest commit to this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related here: #233