New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<cmd + R> should not close open schemas in the sidebar #102

Closed
qwesda opened this Issue Oct 29, 2015 · 10 comments

Comments

Projects
None yet
3 participants
@qwesda

qwesda commented Oct 29, 2015

Every time I create a table through the sql editor and reload the sidebar with <cmd + R> all the opened schemas are getting closed, which gets a bit annoying over time. It would be nice if

a) the open/close states of the schemas in the sidebar would remain stable across reloads
b) CREATE, DROP and maybe ALTER statements would automatically invalidate the corresponding schema and table information

@jakob jakob added the bug label Dec 4, 2015

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda Feb 4, 2016

any chance this (at least the a) part) could make it into the next release?

qwesda commented Feb 4, 2016

any chance this (at least the a) part) could make it into the next release?

@humancopy

This comment has been minimized.

Show comment
Hide comment
@humancopy

humancopy Mar 10, 2017

👍

This is actually quite annoying when opening a table within a schema (sidebar closed), press cmd+r to reload the content, click the schema name in the toolbar (expect to go back to the schema) and all schemas are closed. I keep on opening tables from the main schema every time! 😅

humancopy commented Mar 10, 2017

👍

This is actually quite annoying when opening a table within a schema (sidebar closed), press cmd+r to reload the content, click the schema name in the toolbar (expect to go back to the schema) and all schemas are closed. I keep on opening tables from the main schema every time! 😅

@jakob jakob added this to the v1.1.3 milestone Mar 23, 2017

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob May 9, 2017

Owner

I've now fixed part a) for the sidebar; schemas are now no longer collapsed when reloading.

Please download a recent build and test:
https://eggerapps.at/postico/builds/

Part b) (auto-refreshing after CREATE and ALTER statements) is something I'm probably not going to fix right now. The way it is currently, you at least know you have to refresh manually. If I try to detect changes, it's only going to work in some cases (eg. it might not work when doing changes in a procedure, or when using multiple windows/tabs, etc.). For now I think predictability of the UI is more important, but I might rethink this in the future.

I still need to store expanded schemas for the database view, but I think that is used less than the sidebar.

Owner

jakob commented May 9, 2017

I've now fixed part a) for the sidebar; schemas are now no longer collapsed when reloading.

Please download a recent build and test:
https://eggerapps.at/postico/builds/

Part b) (auto-refreshing after CREATE and ALTER statements) is something I'm probably not going to fix right now. The way it is currently, you at least know you have to refresh manually. If I try to detect changes, it's only going to work in some cases (eg. it might not work when doing changes in a procedure, or when using multiple windows/tabs, etc.). For now I think predictability of the UI is more important, but I might rethink this in the future.

I still need to store expanded schemas for the database view, but I think that is used less than the sidebar.

@humancopy

This comment has been minimized.

Show comment
Hide comment
@humancopy

humancopy May 9, 2017

Yes it's fixed in the sidebar but not in the main view. After reloading the schemas in the main view are closed again. I use the app without the sidebar.

So to reproduce:

  1. Open a schema and go into a table
  2. Reload the data
  3. Click the schema name in the toolbar to go back
  4. Schema is closed in main view - expected to be open

Thanks 😄

humancopy commented May 9, 2017

Yes it's fixed in the sidebar but not in the main view. After reloading the schemas in the main view are closed again. I use the app without the sidebar.

So to reproduce:

  1. Open a schema and go into a table
  2. Reload the data
  3. Click the schema name in the toolbar to go back
  4. Schema is closed in main view - expected to be open

Thanks 😄

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob May 9, 2017

Owner

@humancopy Thanks for testing! Yes, the main view is what I meant with "database view"

Owner

jakob commented May 9, 2017

@humancopy Thanks for testing! Yes, the main view is what I meant with "database view"

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda May 9, 2017

works as advertised for me, Thanks!

I can see how an incomplete implementation for b) might be more annoying than none at all and with the schemas retaining their state CMD+R is already a lotless painful.

qwesda commented May 9, 2017

works as advertised for me, Thanks!

I can see how an incomplete implementation for b) might be more annoying than none at all and with the schemas retaining their state CMD+R is already a lotless painful.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob May 12, 2017

Owner

@humancopy I've now also stored the expanded state of items in the main view -- please test a build from here: https://eggerapps.at/postico/builds/

This issue has proved to be quite a rabbit hole. As I was testing this feature, I realised that there is a lot more state that I should save, eg. the currently selected item, or the current scroll position. And it would be best if the state would be saved across restarts of the app as well -- not just when reloading.

Owner

jakob commented May 12, 2017

@humancopy I've now also stored the expanded state of items in the main view -- please test a build from here: https://eggerapps.at/postico/builds/

This issue has proved to be quite a rabbit hole. As I was testing this feature, I realised that there is a lot more state that I should save, eg. the currently selected item, or the current scroll position. And it would be best if the state would be saved across restarts of the app as well -- not just when reloading.

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda May 13, 2017

nice to hear about selected items/scroll position (#367)!

I'm not sure about maintaining this state across restarts though ... might be little payoff for a lot of hassle and edge cases.

qwesda commented May 13, 2017

nice to hear about selected items/scroll position (#367)!

I'm not sure about maintaining this state across restarts though ... might be little payoff for a lot of hassle and edge cases.

@humancopy

This comment has been minimized.

Show comment
Hide comment
@humancopy

humancopy May 15, 2017

It's working good, just that can see the screen reload, it's not so smooth ... 😄

humancopy commented May 15, 2017

It's working good, just that can see the screen reload, it's not so smooth ... 😄

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Jun 29, 2017

Owner

I'm closing this issue. I think it works good enough for now, and further refinements would need a lot of refactoring.

Owner

jakob commented Jun 29, 2017

I'm closing this issue. I think it works good enough for now, and further refinements would need a lot of refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment