New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query errors should be made more visible #302

Closed
qwesda opened this Issue Dec 9, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@qwesda

qwesda commented Dec 9, 2016

I had the problem, that I had a query which was returning some rows, but also trowing an error. All I was seeing was that the number of rows was to small and that the amount of rows changed depending on what columns were selected.

Turn out that Postgres was throwing an error when casting some values, but since the query status is only shown if no rows are returned it took me longer than necessary to figure out what was going on.

Postico could look for these errors and display a little error symbol (and maybe the number of errors) next to the query status/result dropdown.

Here is an example query that exhibits this behaviour.

SELECT col::numeric
FROM (VALUES ('1.1'), ('not a number')) AS data (col);
@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 15, 2016

Owner

Thanks for reporting this issue, and thanks for the sample query. That's a pretty serious usability problem!

I've made two changes to address this problem:

  • Postico now shows the "Query Status" message by default when an error occurs, even if rows are returned
  • A little status icon is shown in the bottom right corner in the window (yellow for errors, green for success) after the query completes

You can download a prerelease build here:
https://eggerapps-downloads.s3-eu-west-1.amazonaws.com/postico-1540.zip

Owner

jakob commented Dec 15, 2016

Thanks for reporting this issue, and thanks for the sample query. That's a pretty serious usability problem!

I've made two changes to address this problem:

  • Postico now shows the "Query Status" message by default when an error occurs, even if rows are returned
  • A little status icon is shown in the bottom right corner in the window (yellow for errors, green for success) after the query completes

You can download a prerelease build here:
https://eggerapps-downloads.s3-eu-west-1.amazonaws.com/postico-1540.zip

@jakob jakob added the done label Dec 15, 2016

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda Dec 15, 2016

Thanks for the change. This will save people some head scratching in the future.

qwesda commented Dec 15, 2016

Thanks for the change. This will save people some head scratching in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment