New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right Sidebar says "No Row Selected" #336

Closed
jakob opened this Issue Mar 7, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@jakob
Owner

jakob commented Mar 7, 2017

(even though there clearly is a row selected)

I'm not sure how to reproduce this error. Might have something to do with the auto-disconnect setting.

@jakob jakob added the bug label Mar 7, 2017

@jakob jakob modified the milestone: v1.1.2 Mar 22, 2017

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob May 6, 2017

Owner

I've managed to trigger this bug accidentally on macOS 10.10, but don't know how. I have not been able to reproduce it on macOS 10.12

Owner

jakob commented May 6, 2017

I've managed to trigger this bug accidentally on macOS 10.10, but don't know how. I have not been able to reproduce it on macOS 10.12

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob May 6, 2017

Owner

I've been able to reproduce the problem again, however I'm not sure what is causing it. The problem results in tableViewSelectionDidChange no longer being called. This Stack Overflow Answer suggests that the problem could be that I'm calling removeObserver: incorrectly somewhere. That is probably the cause, but I haven't been able to find the exact call that's causing the problem yet.

Owner

jakob commented May 6, 2017

I've been able to reproduce the problem again, however I'm not sure what is causing it. The problem results in tableViewSelectionDidChange no longer being called. This Stack Overflow Answer suggests that the problem could be that I'm calling removeObserver: incorrectly somewhere. That is probably the cause, but I haven't been able to find the exact call that's causing the problem yet.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob May 6, 2017

Owner

I was able to track the error down. It can be triggered by shutting the server down, then pressing "Clear Filter" button twice, then starting the server again and reloading. Then the right sidebar becomes broken.

The problem was indeed an improper call of removeObserver:. I've fixed this specific call site by adding a nil-check. I've also audited the entire code base to make sure I don't have similar errors with removeObserver: in other places, and added some more nil checks to be safe.

Owner

jakob commented May 6, 2017

I was able to track the error down. It can be triggered by shutting the server down, then pressing "Clear Filter" button twice, then starting the server again and reloading. Then the right sidebar becomes broken.

The problem was indeed an improper call of removeObserver:. I've fixed this specific call site by adding a nil-check. I've also audited the entire code base to make sure I don't have similar errors with removeObserver: in other places, and added some more nil checks to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment