Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Temp tables should not be opened automatically #350
I've started to work on this:
There is a minor issue remaining: the left sidebar width is restored incorrectly when the right sidebar was opened. I need to have a look at this.
The 1616 build seems to behave identically to the 1.1.1 version.
steps to reproduce
referenced this issue
Mar 24, 2017
Thanks for the detailed follow-up. Now I understand -- I thought you were talking about window restoration after quitting and restarting Postico, which was also broken.
Since I usually connect with a superuser for testing, I wasn't aware of the issue you described (a superuser can access temp tables from another session).
Anyway, I've now also fixed the issue when using the "new window" or "new tab" commands.
Please try the release candidate build from issue #354 and let me know if it now works as expected!
I made no special case for superuser connections.
I didn't think much about this case before, but now that I did I don't think opening temp tables from a second connection is something you should do, even with a superuser. You can still do it explicitly by right-clicking and holding down the cmd-key and selecting "open contents/structure in new window".
But the default behavior should be that temp tables only appear on the connection that they were created on.
Anyway, thanks for bringing this case to my attention; your frequent input is invaluable!