New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ESC shortcut while editing #379

Closed
ddrscott opened this Issue Apr 27, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@ddrscott

ddrscott commented Apr 27, 2017

The <esc> shortcut while editing has some strange behaviour. I propose dropping it altogether or binding the behaviour to a different key.

When <esc> is typed on an empty line, it adds a capital I. When I hit it again because I don't want an I, the letter doesn't go away. I'm forced to <delete> it away.
When I type "select" then <esc>, it word completes to "selecting". When I hit <esc> again, the "ing" autocompleted "ing" goes away (which is what I would expect).

It would be nice if the behaviour was consistent. Hitting <esc> twice would have the same output as never hitting <esc>.

Also, as a heavy hitter of <esc> as a force of habit (from Vim), it's annoying for anything to happen at all, which is why I would propose for the behaviour to be moved some where else or configurable.

postico-esc

Anyone else having the same issues?

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Apr 27, 2017

Owner

Good point. This is Apple's built-in autocomplete, which is useless in the query view case. I've already disabled it in most text fields; looks like I need to look through the UI and remove it everywhere.

Owner

jakob commented Apr 27, 2017

Good point. This is Apple's built-in autocomplete, which is useless in the query view case. I've already disabled it in most text fields; looks like I need to look through the UI and remove it everywhere.

@jakob jakob added this to the v1.1.3 milestone Apr 27, 2017

@ddrscott

This comment has been minimized.

Show comment
Hide comment
@ddrscott

ddrscott Apr 27, 2017

Wasn't sure how to Google it, but I found the setting on Mac.

https://discussions.apple.com/thread/7311015?start=0&tstart=0

#!/bin/bash
defaults write -g NSUseSpellCheckerForCompletions -bool false

Feel free to close the ticket or keep it open if you want to disable it for the text control.
Note, auto suggest behaviour is also occurs in Preferences -> Rows per page:

ddrscott commented Apr 27, 2017

Wasn't sure how to Google it, but I found the setting on Mac.

https://discussions.apple.com/thread/7311015?start=0&tstart=0

#!/bin/bash
defaults write -g NSUseSpellCheckerForCompletions -bool false

Feel free to close the ticket or keep it open if you want to disable it for the text control.
Note, auto suggest behaviour is also occurs in Preferences -> Rows per page:

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Apr 27, 2017

Owner

@ddrscott Thanks for providing the workaround, but I do consider this a bug in Postico :)

I'll go through all the fields in Postico and disable it everywhere. I really see no point in this feature (escape should probably mean "cancel editing" in most text fields, and do nothing in the query text view)

Owner

jakob commented Apr 27, 2017

@ddrscott Thanks for providing the workaround, but I do consider this a bug in Postico :)

I'll go through all the fields in Postico and disable it everywhere. I really see no point in this feature (escape should probably mean "cancel editing" in most text fields, and do nothing in the query text view)

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob May 2, 2017

Owner

I've investigated this issue, and discovered that Apple has actually changed the default keyboard shortcut for the "complete:" command from Esc to F5 in macOS 10.12. This means that this issue should only affect people on 10.11 and earlier.

Nevertheless, I've started to address this issue. The latest build disables completion in the SQL Text View, in the preferences window, and in the page selection field.

TODO:

  • Favorites Window
  • Filter Bar
  • Table Structure Editor
  • test on older versions of macOS
Owner

jakob commented May 2, 2017

I've investigated this issue, and discovered that Apple has actually changed the default keyboard shortcut for the "complete:" command from Esc to F5 in macOS 10.12. This means that this issue should only affect people on 10.11 and earlier.

Nevertheless, I've started to address this issue. The latest build disables completion in the SQL Text View, in the preferences window, and in the page selection field.

TODO:

  • Favorites Window
  • Filter Bar
  • Table Structure Editor
  • test on older versions of macOS
@ddrscott

This comment has been minimized.

Show comment
Hide comment
@ddrscott

ddrscott May 2, 2017

Guess that means I should upgrade OSX. I'll save that for another day.

about_mac

Thanks for the updates!

ddrscott commented May 2, 2017

Guess that means I should upgrade OSX. I'll save that for another day.

about_mac

Thanks for the updates!

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob May 5, 2017

Owner

Blargh... finally done with this issue. ESC now no longer triggers auto-complete, and aborts editing in text fields as expected, even on older versions of OS X.

In my testing on 10.10 and 10.12 everything seems to work now -- you can now even dismiss the filter bar with ESC (I guess this should have been the standard behavior from the beginning...)

I'd appreciate it if you could download a recent build and try if it works as expected now!

Owner

jakob commented May 5, 2017

Blargh... finally done with this issue. ESC now no longer triggers auto-complete, and aborts editing in text fields as expected, even on older versions of OS X.

In my testing on 10.10 and 10.12 everything seems to work now -- you can now even dismiss the filter bar with ESC (I guess this should have been the standard behavior from the beginning...)

I'd appreciate it if you could download a recent build and try if it works as expected now!

@jakob jakob closed this May 5, 2017

@ddrscott

This comment has been minimized.

Show comment
Hide comment
@ddrscott

ddrscott May 5, 2017

Works great so far. I even undid the OS X setting to make sure.

Thanks!

ddrscott commented May 5, 2017

Works great so far. I even undid the OS X setting to make sure.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment