New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view definition vanishes on click #464

Closed
qwesda opened this Issue Dec 5, 2017 · 11 comments

Comments

Projects
None yet
3 participants
@qwesda

qwesda commented Dec 5, 2017

In the current version (and the dev build 2051) the view definition vanishes when it is selected with the mouse. On mouse_down the text is still displayed (but without syntax highlight) and on mouse_up the text vanishes completely. The text returns when selecting another input component (or by randomly clicking in the view definition field).

I also noticed that the view definition field is not accessible by hitting TAB. After the table comment input field the focus goes to the first column name.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 5, 2017

Owner

Hmm. I can confirm that there is something funny going on with regards to hitting tab, but it behaves different on my machine. I can't leave the view definition field, but I am able to enter it.

I'm on macOS 10.12.6. What version of macOS are you on?

How you connecting to the PostgreSQL server?

Owner

jakob commented Dec 5, 2017

Hmm. I can confirm that there is something funny going on with regards to hitting tab, but it behaves different on my machine. I can't leave the view definition field, but I am able to enter it.

I'm on macOS 10.12.6. What version of macOS are you on?

How you connecting to the PostgreSQL server?

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 5, 2017

Owner

Further testing shows that tabbing seems to work on macOS 10.13. I can't reproduce the text vanishing bug. It's probably related to syntax highlighting. I've seen text disappear from text views when the font could not be found, but I'm not sure why this would happen in this case.

Can you also let me know what database server version you are connecting to?

Owner

jakob commented Dec 5, 2017

Further testing shows that tabbing seems to work on macOS 10.13. I can't reproduce the text vanishing bug. It's probably related to syntax highlighting. I've seen text disappear from text views when the font could not be found, but I'm not sure why this would happen in this case.

Can you also let me know what database server version you are connecting to?

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda Dec 5, 2017

I'm on macOS 10.13.1 and the pg version is 9.5.9.
I think it is related to the length of the view definition - try this view definition: https://gist.github.com/qwesda/402c405234c6b3d75d6cbc5fb26229e3

The TAB issues only happens with MATERIALIZED views ...

qwesda commented Dec 5, 2017

I'm on macOS 10.13.1 and the pg version is 9.5.9.
I think it is related to the length of the view definition - try this view definition: https://gist.github.com/qwesda/402c405234c6b3d75d6cbc5fb26229e3

The TAB issues only happens with MATERIALIZED views ...

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda Dec 5, 2017

The vanishing text is also worse with the MATERIALIZED VIEW ... sorry for the confusing description

qwesda commented Dec 5, 2017

The vanishing text is also worse with the MATERIALIZED VIEW ... sorry for the confusing description

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda Dec 5, 2017

here is a gif of how it looks on my machine:

out

qwesda commented Dec 5, 2017

here is a gif of how it looks on my machine:

out

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 6, 2017

Owner

OK, thanks for the GIF. I've now been able to reproduce the vanishing text issue in a VM running macOS 10.13 beta. I'll see if I can somehow attach a debugger in the VM.

I've created a separate issue for the tab capture problem on 10.12 #465

As for not being able to tab into a materialized view definition, that is by design. The view definition of a materialized view can not be changed, so the text field is read-only, and therefore it is skipped when tabbing.

Owner

jakob commented Dec 6, 2017

OK, thanks for the GIF. I've now been able to reproduce the vanishing text issue in a VM running macOS 10.13 beta. I'll see if I can somehow attach a debugger in the VM.

I've created a separate issue for the tab capture problem on 10.12 #465

As for not being able to tab into a materialized view definition, that is by design. The view definition of a materialized view can not be changed, so the text field is read-only, and therefore it is skipped when tabbing.

@postico-bot

This comment has been minimized.

Show comment
Hide comment
@postico-bot

postico-bot Dec 6, 2017

We have been working on this issue!

Avoid updating the font of the SQL Text View if it hasn't actually changed.

Before this change, font updates triggered redraws, which sometimes again triggered a font update on High Sierra.
It seems that this was the cause for issue #464 (vanishing text in view definition field) (jakob)

Please download Build 2077, or check out the list of recent builds.

We would love to hear your thoughts!

postico-bot commented Dec 6, 2017

We have been working on this issue!

Avoid updating the font of the SQL Text View if it hasn't actually changed.

Before this change, font updates triggered redraws, which sometimes again triggered a font update on High Sierra.
It seems that this was the cause for issue #464 (vanishing text in view definition field) (jakob)

Please download Build 2077, or check out the list of recent builds.

We would love to hear your thoughts!

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 12, 2017

Owner

@qwesda I think I've fixed this issue. If everything goes well, we're planning to release a new version of Postico this week. Could you let me know if one of the recent builds (2097 or later) work for you?

Owner

jakob commented Dec 12, 2017

@qwesda I think I've fixed this issue. If everything goes well, we're planning to release a new version of Postico this week. Could you let me know if one of the recent builds (2097 or later) work for you?

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda Dec 12, 2017

work fine in build 2108, thx!

The syntax highlighting still disappears on mouse_down when initially clicking in the field, but thats not so important.

qwesda commented Dec 12, 2017

work fine in build 2108, thx!

The syntax highlighting still disappears on mouse_down when initially clicking in the field, but thats not so important.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 12, 2017

Owner

Right, syntax highlighting does disappear while the mouse is down. It should reappear quickly after releasing the mouse. This is because the cocoa text system actually puts another view on top of the text field as soon as you start editing, so I need to reparse the text. Maybe I can find a way to pass the parse result so I don't need to reparse...

Owner

jakob commented Dec 12, 2017

Right, syntax highlighting does disappear while the mouse is down. It should reappear quickly after releasing the mouse. This is because the cocoa text system actually puts another view on top of the text field as soon as you start editing, so I need to reparse the text. Maybe I can find a way to pass the parse result so I don't need to reparse...

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda Dec 12, 2017

It's only a very minor thing ... and it sounds like some ugly hacks might be required to make this happen.

qwesda commented Dec 12, 2017

It's only a very minor thing ... and it sounds like some ugly hacks might be required to make this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment