New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3 with Redshift crashes when auto-completion shows #470

Closed
KOBA789 opened this Issue Dec 14, 2017 · 10 comments

Comments

Projects
None yet
4 participants
@KOBA789

KOBA789 commented Dec 14, 2017

Procedure to reproduce:

  1. Connect to a Redshift.
  2. Open "SQL Query" view.
  3. Type some SQL: select * from some_schema.
  4. Finally, type ..
  5. A popup appears and then Postico crashes immediately.

Crash Report: https://gist.github.com/KOBA789/229b394adbbd7cde26a95fa0dce31666

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 14, 2017

Owner

Thanks for the crash report! We couldn‘t reproduce the issue you describe (it works on our Redshift test cluster), but we tried to make Postico more resilient wrt. NULL responses from the server.

Can you check if build 2144 works for your database?

https://eggerapps.at/postico/builds/

Owner

jakob commented Dec 14, 2017

Thanks for the crash report! We couldn‘t reproduce the issue you describe (it works on our Redshift test cluster), but we tried to make Postico more resilient wrt. NULL responses from the server.

Can you check if build 2144 works for your database?

https://eggerapps.at/postico/builds/

@KOBA789

This comment has been minimized.

Show comment
Hide comment
@KOBA789

KOBA789 Dec 14, 2017

Thanks for your quick response!

I tried build 2144 and it never crashes!

My broken version which was downloaded via the update notification is 2142.
Are there any differences?

KOBA789 commented Dec 14, 2017

Thanks for your quick response!

I tried build 2144 and it never crashes!

My broken version which was downloaded via the update notification is 2142.
Are there any differences?

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 14, 2017

Owner

Yes, build 2144 has additional checks for NULL values. (Martin added them after looking at your crash report)

Owner

jakob commented Dec 14, 2017

Yes, build 2144 has additional checks for NULL values. (Martin added them after looking at your crash report)

@teej-minted

This comment has been minimized.

Show comment
Hide comment
@teej-minted

teej-minted Dec 14, 2017

After doing loads more testing (after the last email I sent you @jakob), I believe that it's some kind of race condition type of issue. I am still having crashes on 2144. If I go very slowly I don't crash, if I go normal speed I crash.

teej-minted commented Dec 14, 2017

After doing loads more testing (after the last email I sent you @jakob), I believe that it's some kind of race condition type of issue. I am still having crashes on 2144. If I go very slowly I don't crash, if I go normal speed I crash.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 14, 2017

Owner

@teej-minted Thanks for trying the new build. I think you found an unrelated crash. I'll investigate tomorrow morning.

Owner

jakob commented Dec 14, 2017

@teej-minted Thanks for trying the new build. I think you found an unrelated crash. I'll investigate tomorrow morning.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 15, 2017

Owner

Short update on the crash reports: We‘ve analysed them, and discovered that the crash is caused by a memory error. (We think that the items in the suggestion list are released too early)

We’ve not yet found the root cause of the issue, and we also haven‘t been able to reproduce the crash yet.

I think that so far we‘ve had reports of the problem only on Redshift, but oddly everything works on our Redshift test cluster.

I‘ll keep investigating the problem. In the mean time, you can use version 1.2.4 until the issue is fixed: https://eggerapps.at/postico/legacy.html

Owner

jakob commented Dec 15, 2017

Short update on the crash reports: We‘ve analysed them, and discovered that the crash is caused by a memory error. (We think that the items in the suggestion list are released too early)

We’ve not yet found the root cause of the issue, and we also haven‘t been able to reproduce the crash yet.

I think that so far we‘ve had reports of the problem only on Redshift, but oddly everything works on our Redshift test cluster.

I‘ll keep investigating the problem. In the mean time, you can use version 1.2.4 until the issue is fixed: https://eggerapps.at/postico/legacy.html

@postico-bot

This comment has been minimized.

Show comment
Hide comment
@postico-bot

postico-bot Dec 18, 2017

We have been working on this issue!

Committed by jakob:

  • fixed a memory ownership error that sometimes caused a crash on macOS 10.11 when using Autocomplete #470
  • fix a potential race condition when grouping suggestions for the sidebar

Download Build 2151, or check out the list of recent builds.

postico-bot commented Dec 18, 2017

We have been working on this issue!

Committed by jakob:

  • fixed a memory ownership error that sometimes caused a crash on macOS 10.11 when using Autocomplete #470
  • fix a potential race condition when grouping suggestions for the sidebar

Download Build 2151, or check out the list of recent builds.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 18, 2017

Owner

We've finally been able to reproduce the second crash. It has nothing to do with Redshift, but it happens only on macOS 10.11. It can be triggered for example by typing "pg_", then pressing the tab key three times, then pressing return.

We've addressed the underlying problem (we forgot to call -reloadData in some cases).

@teej-minted Could you verify that build 2151 works for you now?

Owner

jakob commented Dec 18, 2017

We've finally been able to reproduce the second crash. It has nothing to do with Redshift, but it happens only on macOS 10.11. It can be triggered for example by typing "pg_", then pressing the tab key three times, then pressing return.

We've addressed the underlying problem (we forgot to call -reloadData in some cases).

@teej-minted Could you verify that build 2151 works for you now?

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Dec 19, 2017

Owner

We've released Postico 1.3.1 which should fix both issues reported here. I'm closing this issue. If the crash still occurs, you can reopen this issue, or create a new one.

Thanks a lot for your feedback!

Owner

jakob commented Dec 19, 2017

We've released Postico 1.3.1 which should fix both issues reported here. I'm closing this issue. If the crash still occurs, you can reopen this issue, or create a new one.

Thanks a lot for your feedback!

@jakob jakob closed this Dec 19, 2017

@teej-minted

This comment has been minimized.

Show comment
Hide comment
@teej-minted

teej-minted Dec 19, 2017

Just tested v 1.3.1 (2153) and it works great for me with no crashes!

teej-minted commented Dec 19, 2017

Just tested v 1.3.1 (2153) and it works great for me with no crashes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment