New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Completion Beep is annoying #513

Closed
jakob opened this Issue Mar 7, 2018 · 10 comments

Comments

Projects
None yet
4 participants
@jakob
Owner

jakob commented Mar 7, 2018

When pressing Tab to complete a word, Postico beeps if multiple completions are possible. Pressing Tab a second time shows completions.

(We wanted tab completion in Postico to be similar to tab completion in Bash.)

However, it seems that some people don't like the beep (myself included).

Does anybody like the beep?

@martinjankoehler

This comment has been minimized.

Collaborator

martinjankoehler commented Mar 19, 2018

We have been working on this issue!

Related changes:

  • In case of ambiguity, possible suggestions are now shown directly without beeping.
  • Bugfix: Inserting tab symbols after a tab-completed keyword works now
  • Bugfix: Inserting tab symbol after "No Completions" works now

Download Build B2491, or check out the list of recent builds.

@deanmorin

This comment has been minimized.

deanmorin commented Mar 21, 2018

Hey guys! I tried out 2941, but I'm not sure how the new completion style is supposed to work.

CREATE SCHEMA a;
CREATE TABLE a.foo (n integer);
CREATE TABLE a.foo_bar (n integer);
CREATE TABLE a.foo_foo (n integer);

If I start typing from the schema name, tab just inserts a tab character (| shows starting position):

|a. tab --> a.\t
|a.f tab --> a.f\t

If the schema name is already there, it sort of does tab completion:

a.| tab --> a.foo

Sometimes it just picks one for you like vim completion, but without the ability to cycle through options. Other times it seems to sort of behave like bash completion. Sometimes tab cycles the completion window on and off.

Other than the bell, I much preferred the previous completion style.

@postico-bot

This comment has been minimized.

postico-bot commented Mar 23, 2018

We have been working on this issue!

martin: AutoComplete: fixes for tab completion after dot (autotrigger turned off) #513

Download Build B2518, or check out the list of recent builds (NOTE: old B2516 link was updated to newer build)

@martinjankoehler

This comment has been minimized.

Collaborator

martinjankoehler commented Mar 26, 2018

@deanmorin Thanks for the feedback, this is a bug we have now fixed in Build B2518

Tab will now only autocommit common prefixes whenever unambiguous.
In case of ambiguity, tab will yield a beep, but never autocommit the selected suggestion (this can be done with up/down/enter).
When initiating an autocomplete session via tab, in case of ambiguity, the initial beep is now intentionally gone, instead the list of alternatives suggestions is immediatly shown.

Please let us know in case of any other issues.

Thanks again,
-- Martin

Repository owner deleted a comment from postico-bot Mar 26, 2018

@postico-bot

This comment has been minimized.

postico-bot commented Mar 26, 2018

We have been working on this issue!

martin: AutoComplete: fixes for tab completing an escape-triggered auto complete session in context of an empty token after newline #513

Download Build B2518, or check out the list of recent builds.

@postico-bot

This comment has been minimized.

postico-bot commented Mar 26, 2018

We have been working on this issue!

martin: AutoComplete: suppress „No other Completions“ when triggering tab immediatly after commit #513

Download Build B2522, or check out the list of recent builds.

@postico-bot

This comment has been minimized.

postico-bot commented Mar 26, 2018

We have been working on this issue!

martin: AutoComplete bugfix: removed invalid beep when pressing newline immediately after display of ‚no other completions‘ #513

Download Build B2523, or check out the list of recent builds.

@postico-bot

This comment has been minimized.

postico-bot commented Mar 28, 2018

We have been working on this issue!

martin: Autocomplete improvements (tab completion and UX related) #513 #491 #478 #474

Download Build B2542, or check out the list of recent builds.

@jakob

This comment has been minimized.

Owner

jakob commented Apr 4, 2018

We've just released 1.3.3, with the improved tab completion. It should beep a lot less, now, and still behave similar to bash!

Thanks for all the feedback!

@jakob jakob closed this Apr 4, 2018

@deanmorin

This comment has been minimized.

deanmorin commented Apr 4, 2018

Works wonderfully now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment