New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error Reporting on CSV Import #564

Closed
citizenfish opened this Issue Jun 21, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@citizenfish

citizenfish commented Jun 21, 2018

When importing a large CSV file Postico can report errors at a row level which is good. However, it would be much better if it showed the row in question so that the error could be properly debugged.

For example:-

screen shot 2018-06-21 at 08 38 42

Here we can see a problem with row 336797. In vi this row looks to be perfectly fine and there is no character 'L' on that row. So it may be that postico has calculated a different row number? It would be easier to troubleshoot if we could see the data concerned.

@citizenfish

This comment has been minimized.

citizenfish commented Jun 22, 2018

Further to this. That error is a BUG

If I reduce the file to 100,000 lines I still get the same error. So row does not refer to the data at all

@jakob

This comment has been minimized.

Owner

jakob commented Jun 22, 2018

Hi @citizenfish! Thanks for the bug report.

Is it possible that there are some non-standard line break characters in the file?

Is there any chance you can send us a copy of the file (either to postico@eggerapps.at or to my personal email address jakob@eggerapps.at). If not, is it possible to create an extract of the file that still exhibits the problem, but does not contain confidential data?

@citizenfish

This comment has been minimized.

citizenfish commented Jun 22, 2018

You have mail jakob. It is open data so no sensitivities

@jakob

This comment has been minimized.

Owner

jakob commented Jun 22, 2018

OK, got it, I can reproduce the error on my machine. I'll get back to you once I know more!

@jakob

This comment has been minimized.

Owner

jakob commented Jun 22, 2018

OK, it looks like we're counting rows wrong. The problem is actually in line 28068.

We'll fix the bug next week!

As for displaying the problematic row, that would of course be very convenient, but right now Postico is configured to only show a 1MB preview of the file for performance reasons. If the error is later in the file, we can't show it. I need to think about this.

@jakob

This comment has been minimized.

Owner

jakob commented Jul 5, 2018

We've fixed this in build 2991, which you can download here: https://eggerapps-downloads.s3.eu-west-1.amazonaws.com/postico-2991.zip

Postico now reports the correct line number, and the error message also includes the value that could not be converted to a number, which is hopefully more helpful.

Thanks again for reporting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment