New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much padding/whitespace in result grid #87

Closed
wellsoliver opened this Issue Oct 14, 2015 · 14 comments

Comments

Projects
None yet
3 participants
@wellsoliver

wellsoliver commented Oct 14, 2015

The result grid is too padded, or the columns are too wide in the results grid. I'm wondering if there is a way to set it so the columns are only as wide as their column names, or perhaps an option to auto adjust for the widest amount of data. I just see columns that are 3 or 5x wider than the column name and the data shown, not sure why...

@wellsoliver

This comment has been minimized.

Show comment
Hide comment
@wellsoliver

wellsoliver commented Oct 14, 2015

screen shot 2015-10-14 at 11 55 41 am

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Oct 14, 2015

Owner

At the moment Postico has default column widths for different each data type. You can autosize a column by double clicking the separator. Postico will also remember when you changed column widths and you open the table again next time.

I agree that it might be useful to autosize columns based on their actual contents.

Owner

jakob commented Oct 14, 2015

At the moment Postico has default column widths for different each data type. You can autosize a column by double clicking the separator. Postico will also remember when you changed column widths and you open the table again next time.

I agree that it might be useful to autosize columns based on their actual contents.

@wellsoliver

This comment has been minimized.

Show comment
Hide comment
@wellsoliver

wellsoliver Oct 27, 2015

The double clicking to autosize thing works great-- wondering why the query grid result can't be sized in that manner by default?

wellsoliver commented Oct 27, 2015

The double clicking to autosize thing works great-- wondering why the query grid result can't be sized in that manner by default?

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Oct 27, 2015

Owner

Autosizing can only be done after the data has finished loading, but the columns are already displayed as soon as the metadata is loaded. I wanted to avoid changing column sizes automatically after they have already been displayed since that would lead to the interface jerking around. Sudden changes in the UI that are not caused by user actions can lead to poor user experiences.

But I see now that the current behavior isn't very good either, so I will change this in the future.

Owner

jakob commented Oct 27, 2015

Autosizing can only be done after the data has finished loading, but the columns are already displayed as soon as the metadata is loaded. I wanted to avoid changing column sizes automatically after they have already been displayed since that would lead to the interface jerking around. Sudden changes in the UI that are not caused by user actions can lead to poor user experiences.

But I see now that the current behavior isn't very good either, so I will change this in the future.

@wellsoliver

This comment has been minimized.

Show comment
Hide comment
@wellsoliver

wellsoliver Oct 29, 2015

cool, just a thought: maybe a button that's enabled after all data is fetched that auto-sizes all cells?

wellsoliver commented Oct 29, 2015

cool, just a thought: maybe a button that's enabled after all data is fetched that auto-sizes all cells?

@jakob jakob added the enhancement label Dec 4, 2015

@wellsoliver

This comment has been minimized.

Show comment
Hide comment
@wellsoliver

wellsoliver Dec 5, 2015

just +1ing myself here, it's really a drag on the workload to constantly resize the cells after pulling a query-- maybe a quick button or preference to autosize all columns after query complete or something?

wellsoliver commented Dec 5, 2015

just +1ing myself here, it's really a drag on the workload to constantly resize the cells after pulling a query-- maybe a quick button or preference to autosize all columns after query complete or something?

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Jan 26, 2016

Owner

I've now implemented an algorithm that tries to intelligently resize table columns. Could you try the following build to see if it works as you expect?
https://eggerapps-downloads.s3.amazonaws.com/postico-1304.zip

Owner

jakob commented Jan 26, 2016

I've now implemented an algorithm that tries to intelligently resize table columns. Could you try the following build to see if it works as you expect?
https://eggerapps-downloads.s3.amazonaws.com/postico-1304.zip

@jakob jakob added the started label Jan 26, 2016

@wellsoliver

This comment has been minimized.

Show comment
Hide comment
@wellsoliver

wellsoliver Jan 26, 2016

!!! After a only a few hours using it this AM, it's a wonderful improvement. I haven't seen anything totally weird or exploded. It's a big improvement. Thank you!

wellsoliver commented Jan 26, 2016

!!! After a only a few hours using it this AM, it's a wonderful improvement. I haven't seen anything totally weird or exploded. It's a big improvement. Thank you!

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Jan 26, 2016

Owner

Good to hear! I ended up with quite an elaborate algorithm to size the columns; if you run into any odd cases let me know!

Owner

jakob commented Jan 26, 2016

Good to hear! I ended up with quite an elaborate algorithm to size the columns; if you run into any odd cases let me know!

@jopotts

This comment has been minimized.

Show comment
Hide comment
@jopotts

jopotts Jan 29, 2016

Tried 1304 and it's working well for me. There's a very slight extra delay on first viewing a table compared to the current (1292) build but hardly noticeable and worth it for the benefits.

Also I may as well cross-re-raise-reminder the issue of the rows being double height whilst I'm here: #26

You're doing an amazing job @jakob! Thanks!

jopotts commented Jan 29, 2016

Tried 1304 and it's working well for me. There's a very slight extra delay on first viewing a table compared to the current (1292) build but hardly noticeable and worth it for the benefits.

Also I may as well cross-re-raise-reminder the issue of the rows being double height whilst I'm here: #26

You're doing an amazing job @jakob! Thanks!

@jopotts

This comment has been minimized.

Show comment
Hide comment
@jopotts

jopotts Mar 2, 2016

Loving the recent enhancements. This issue is pretty much ready to close although I've discovered one very minor thing: animated gif

I think it happens when the first column gets truncated to ellipses due to width restrictions (when first displaying the results), then when expanding the column it doesn't refresh for some reason. Possibly an OSX issue and out of your control.

jopotts commented Mar 2, 2016

Loving the recent enhancements. This issue is pretty much ready to close although I've discovered one very minor thing: animated gif

I think it happens when the first column gets truncated to ellipses due to width restrictions (when first displaying the results), then when expanding the column it doesn't refresh for some reason. Possibly an OSX issue and out of your control.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Mar 2, 2016

Owner

@jopotts thanks for reporting this -- this looks like a horrible bug, and completely my fault (there's an error in the caching logic). This build should fix it: https://eggerapps-downloads.s3-eu-west-1.amazonaws.com/postico-1343.zip

Owner

jakob commented Mar 2, 2016

@jopotts thanks for reporting this -- this looks like a horrible bug, and completely my fault (there's an error in the caching logic). This build should fix it: https://eggerapps-downloads.s3-eu-west-1.amazonaws.com/postico-1343.zip

@jopotts

This comment has been minimized.

Show comment
Hide comment
@jopotts

jopotts Mar 3, 2016

I tried the new build and can't reproduce the issue. Thanks for the quick fix.

jopotts commented Mar 3, 2016

I tried the new build and can't reproduce the issue. Thanks for the quick fix.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Mar 4, 2016

Owner

fixed in 1.0.5

Owner

jakob commented Mar 4, 2016

fixed in 1.0.5

@jakob jakob closed this Mar 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment