Permalink
Browse files

fix #434 iframe tests timing out in devmode

Iframe loader kept waiting indefinitely for the skin to be loaded
in dev mode. This was a clear code mistake, since the skin is loaded
actually later in loadSkin() function.

The problem was manifesting itself in browser-based test runner.
An example failing test: test.aria.widgets.container.dialog.MaximizableDialogTest
  • Loading branch information...
1 parent f489ae6 commit c11daa31f7ac66fa039c034e12ac06514a2514f3 @jakub-g committed Mar 21, 2013
Showing with 1 addition and 2 deletions.
  1. +1 −2 test/iframeLoaderOs.js
@@ -33,8 +33,7 @@
window.loader = {
changeRootFolder : function () {
// Need to wait for some special classes to be here, before to continue
- if (window.Aria && window.aria && window.aria.core && window.aria.core.DownloadMgr && aria.core.MultiLoader
- && (!isDev || (aria.widgets && aria.widgets.AriaSkin))) {
+ if (window.Aria && window.aria && window.aria.core && window.aria.core.DownloadMgr && aria.core.MultiLoader) {
Aria.rootFolderPath = baseUrl + "/";
aria.core.DownloadMgr.updateRootMap({
"aria" : {

0 comments on commit c11daa3

Please sign in to comment.