Jakub Holy jakubholynet

Organizations

Iterate AS
Jakub Holy
  • Jakub Holy 31ffad9
    Add nodejs-repl and eval commands for it
Jakub Holy
  • Jakub Holy e783e29
    Emacs: prettify ‘function’ as λ etc.
Jakub Holy
Jakub Holy

This is my result after commenting out the defdvice and restarting Emacs: ergoemacs-install-shortcuts-up 48 1.2459979999 0.0259582916 ergoemacs-pos…

Jakub Holy

My results are ergoemacs-install-shortcuts-up 10 1.1537069999 0.1153706999 ergoemacs-post-command-hook 5 1.1535819999 0.2307164 ergoemacs-install-s…

Jakub Holy

This workaround does not cause any visible improvement for me. I do not understand how it works so it is difficult to guess why :( According to des…

jakubholynet commented on issue progrium/buildstep#81
Jakub Holy

Nice. It is not easy for me anymore to try this out since I am away from the project where I experienced the problem but I will try to find the tim…

Jakub Holy

I see your point though I don't think that using the name to indicate it is a good solution. It feels like leveraging an existing bug to cause a pr…

Jakub Holy

[substring]shouldReturnFromIndexToEnd

Jakub Holy

sometimes you use "base" sometimes "initial" #consistency

Jakub Holy

haven't I seen this test before?? And aren't there multiple dufferent cases of substrings? Do we test all of them here?

Jakub Holy

I miss deleting also in the middle, at the end and perhaps what if I try to delete beyond the end. Also, you sometimes use "should" sometimes not i…

Jakub Holy

shouldConcatStringOntoCString ?

Jakub Holy

shouldConcatTwoCStrings ?

Jakub Holy

I have to map mentally what 1st/2nd substring corresponds to. I might prefer substringBC and substringC

Jakub Holy

It looks like you are paied by LOC :-) final int index = 3; final String original = "some text"; assertThat(new CString(original).substring(index).t…

Jakub Holy

Isn't this the same as the previous one? Plus WTF is "eval", there is no such method?! WTF is "basic value"?!

Jakub Holy

thank you for this useful javadoc line #irony ;)

Jakub Holy

shouldReturnSameStringAsCreatedFrom?

Jakub Holy

It's 'OperationsTest' but you call it "basic operations" so either drop "basic" or call it BasicOperationsTest #consistency

Jakub Holy

same as above => shouldReturnSubstringFromIndexToEndIfRequestedMoreThanAvailable

Jakub Holy

The name provides way to little context, too far from biz requirement lang. => shouldReturnEmptyStringIfIndexAtOrBeyondEnd Also I suppose we shoul…

Jakub Holy

I really dislike this one: Name - no reference to actual business requirement "foobar" is name with 0 domain knowledge value, as is "s" I do not u…

Jakub Holy

Maybe we could also prove we can actually construct some non-null instance? And a question that immediatelly pops out, what about ""?

Jakub Holy

Maybe you record too much impl. details in the name? If you switch to a different exception (f.e.x. IllegalArgument which I prefer) you;d need to r…

Jakub Holy

Empty files? WTF?

Jakub Holy

Nooo! How can you call it end?! In JDK end, or rather endIndex is actually an index. If you want "number of chars" then you - well, at least JDK - …