font-family quotes being stripped #250

Closed
jpdesigndev opened this Issue Feb 28, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@jpdesigndev

Issue originally discussed in GoalSmashers#94 (comment)

I'm using the font-family for named media queries as proposed in the CSS-Tricks article, Making Sass talk to JavaScript with JSON. The thing is, when put a JSON string in a CSS font-family declaration, clean-css, strips my quotes.

For example,

font-family: '{ "current" : "large", "all" : ["small", "medium", "large"], "position" : 2 }'

Minifies to

font-family: {current:large,all:[small,medium,large],position:2}

I understand that this is a bit awkward, but seems to be the best way to define breakpoints in only one place.

GoalSmashers added a commit that referenced this issue Mar 1, 2014

Fixes #250 - correctly handle JSON data in quotations.
It's a quick fix. Proper one comes soon to master.
@GoalSmashers

This comment has been minimized.

Show comment Hide comment
@GoalSmashers

GoalSmashers Mar 1, 2014

Contributor

@jpdesigndev there's a quick fix for 2.1.4 with a more flexible solution coming in 2.2.

Contributor

GoalSmashers commented Mar 1, 2014

@jpdesigndev there's a quick fix for 2.1.4 with a more flexible solution coming in 2.2.

@jpdesigndev

This comment has been minimized.

Show comment Hide comment
@jpdesigndev

jpdesigndev Mar 1, 2014

@GoalSmashers Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment