Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bug with IE backslash hack in clean-css 3.3.2 #603

Closed
hostep opened this issue Jun 15, 2015 · 7 comments
Closed

New bug with IE backslash hack in clean-css 3.3.2 #603

hostep opened this issue Jun 15, 2015 · 7 comments

Comments

@hostep
Copy link

hostep commented Jun 15, 2015

Hi

In clean-css 3.3.1 this works:

➜ echo 'input { margin: 4px 0 0; margin-top: 1px \9; }' | ./cleancss
input{margin:4px 0 0;margin-top:1px \9}

After updating to clean-css 3.3.2, the IE hack is being removed:

➜ echo 'input { margin: 4px 0 0; margin-top: 1px \9; }' | ./cleancss
input{margin:4px 0 0}

Thanks!

@hostep
Copy link
Author

hostep commented Jun 15, 2015

Just a small update.

I can get it back by running:

➜ echo 'input { margin: 4px 0 0; margin-top: 1px \9; }' | ./cleancss --compatibility '*,+properties.ieSuffixHack'
input{margin:4px 0 0;margin-top:1px\9}

But since the hack targets IE 9 and lower and your default compatibility targets IE 9 and up I think it should work without the compatibility flag.
Or am I missing something here?

@jakubpawlowicz
Copy link
Collaborator

@hostep If you need that hack in IE9 then please use --compatibility '*,+properties.ieSuffixHack' for the moment. The reason it's removed now is because of #602, so your code should have broken much earlier than in 3.3.2, but it didn't because that case was handled incorrectly.

@jakubpawlowicz
Copy link
Collaborator

On the second thoughts I think you are right - it's rather counter intuitive to have properties.ieSuffixHack set to false by default since clean-css is IE9+ by default. I'll change it to true in 3.3.3.

@hostep
Copy link
Author

hostep commented Jun 16, 2015

Yes, I agree. Thanks!

jakubpawlowicz added a commit that referenced this issue Jun 16, 2015
It works up to IE9 and we have IE9 mode on by default!
@jakubpawlowicz
Copy link
Collaborator

👍 Fixed in 3.3.3.

@hostep
Copy link
Author

hostep commented Jun 16, 2015

Tested and it works as expected again.

Thanks!

@jakubpawlowicz
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants