New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dist/ #284

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@davidgoli
Collaborator

davidgoli commented Oct 1, 2018

dist/ can be built at any time for deployment. It should continue to be built in the pre-commit hook to ensure each commit can build.

@davidgoli davidgoli added WIP and removed WIP labels Oct 1, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Oct 1, 2018

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files          21       21           
  Lines        1909     1909           
  Branches      572      572           
=======================================
  Hits         1706     1706           
  Misses        203      203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a169ea2...0533319. Read the comment docs.

@davidgoli davidgoli merged commit a23fe61 into master Oct 1, 2018

4 checks passed

codecov/patch Coverage not affected when comparing a169ea2...0533319
Details
codecov/project 89.36% remains the same compared to a169ea2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@davidgoli davidgoli deleted the remove-dist branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment