Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #16 Cannot install on windows - Patch #47

Merged
merged 5 commits into from Oct 13, 2019

Conversation

@woodsjs
Copy link
Contributor

woodsjs commented Oct 7, 2019

Fixes issue where install looks for poppler lib and include in different directory than Anaconda installed it.
Updates readme with install instructions for Windows.

woodsjs added 5 commits Oct 1, 2019
When attempting to install pdftotext via pip install on Windows, there are several missing dependency errors.
This code specifically fixes the issue of missing poppler-document.h and missing poppler-cpp.lib.  
These files exist after a conda install poppler, though they are not found in the include or library directories that are being used.

This also quits if CONDA_PREFIX is None, which means that conda is not installed, or the environment variable has been whacked.
Moved Conda Users libgcc section under Unix section.
Moved Windows section to the end, prior to install to make it read easier.
@jalan

This comment has been minimized.

Copy link
Owner

jalan commented Oct 8, 2019

Thanks! This should be a big help to the people who have asked for Windows support in the past.

I wonder if I can set up AppVeyor to automatically test the Windows build.

In any case, I plan to merge this shortly.

@woodsjs

This comment has been minimized.

Copy link
Contributor Author

woodsjs commented Oct 9, 2019

Great! As for AppVeyor, it looks like there is support for Miniconda/Miniconda3 which this patch works with. It also looks like you can enable c++ tools in the yml file.
I don't have any personal experience with AppVeyor, but should be doable.

@jalan jalan self-assigned this Oct 11, 2019
@jalan jalan merged commit ae340d8 into jalan:master Oct 13, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@woodsjs woodsjs deleted the woodsjs:cannot-install-on-windows-patch branch Oct 24, 2019
@RVerma93

This comment has been minimized.

Copy link

RVerma93 commented Dec 4, 2019

First off, big thanks to everybody for contributing to fixing this.

I'm getting this in perpetuity when trying to forge poppler.

Collecting package metadata (current_repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: failed

Any ideas?

@woodsjs

This comment has been minimized.

Copy link
Contributor Author

woodsjs commented Dec 5, 2019

Hey @RVerma93 have you tried
conda install -c conda-forge poppler
That usually works.

@woodsjs

This comment has been minimized.

Copy link
Contributor Author

woodsjs commented Dec 5, 2019

Hey @RVerma93 thanks for the screenshot. There's a reported issue with conda documented here conda/conda#9367 that outlines the issue you're having with some workarounds. It looks like it might be conflicts between the conda version and python version. You might want to follow some of the advice there for resolving the issue (downgrade or create venv specifying python version).

For the setup.py, clone the master branch of this repo, You'll need MS Visual C++ libraries installed as well. Move into the pdftotext directory created when you cloned it. If you pip search pdftotext you'll probably see just the package listed with no install. Run python setup.py install. If all goes well pdftotext should be built and you'll have the globally installed package, verified with the pip search pdftotext command which should give you an INSTALLED line with the current version.

@RVerma93

This comment has been minimized.

Copy link

RVerma93 commented Dec 5, 2019

@woodsjs Thank you! It was as simple as playing around with the conda versions, it seems like the newest version of conda did the trick, and the rest was as instructed. For those facing similar issues, simply run conda update --all and see if that works. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.