Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plugable not authorized page #525

Merged
merged 1 commit into from Nov 6, 2015
Merged

Conversation

lukestephenson
Copy link
Contributor

Previously was hardcoded to the securesocial implementation. Now allowing
custom not authorized pages to be rendered.

Fixes #499


Note that I've tested this manually by publishing and using from my application which is using securesocial. I wasn't able to get the securesocial unit tests running. Invoking sbt test with a fresh clone of master resulted in compilation errors in the sample projects. Can you please document how the tests should be run.

eg

[error] C:\developer\workspace\securesocial\samples\scala\demo\test\ApplicationSpec.scala:6: object testkit is not a member of package securesocial
[error] import securesocial.testkit.WithLoggedUser

Even if I limit to the core tests with sbt "project core" test some tests fail to pass? Is this correct or something broken in my setup?

[info] GoogleLoginSpec
[info]
[info] an application using secure social should
[info] x log a valid google user
[error]    'Some(http:///login)' is not equal to 'Some(/)' (GoogleLoginSpec.scala:61)

Thanks

Previously was hardcoded to the securesocial implementation.  Now allowing
custom not authorized pages to be rendered.

Fixes jaliss#499
@lloydmeta
Copy link

👍 for this.

jaliss added a commit that referenced this pull request Nov 6, 2015
Use plugable not authorized page
@jaliss jaliss merged commit ea38c1f into jaliss:master Nov 6, 2015
@jaliss
Copy link
Owner

jaliss commented Nov 6, 2015

thanks @lukestephenson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Not Authorized page
3 participants