ci: align npm publish workflow with npm OIDC docs#15
Merged
Conversation
Bumps actions/checkout and actions/setup-node to v6 and node-version to 24 to match npm's Trusted Publishing example. Node 24 ships npm >= 11.5.1, which is required for the OIDC token exchange — Node 22 was shipping npm 10.x so the publish was falling back to anonymous and returning a misleading 404 from the registry.
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: "22" | ||
| node-version: "24" |
There was a problem hiding this comment.
🚩 Volta-pinned Node version diverges significantly from CI
The package.json:60-62 pins Node to 18.19.0 via Volta, while this workflow now uses Node 24. This was already a mismatch before the PR (Node 22 vs Volta 18), but the gap is widening. If any dependency or build step relies on Volta's pinned version semantics, the CI publish environment may behave differently from local development. This is a pre-existing inconsistency but worth being aware of.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan