New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect firefox-nightly #82

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
2 participants
@pimterry
Copy link

pimterry commented Jan 22, 2019

Firefox Nightly is the nightly build of Firefox. It's distributed as a standalone tarball, so it can in theory could be installed with any name, but many of the published packages (e.g. for Arch) put it into your PATH as firefox-nightly.

Right now, in that case it isn't detected by james-browser-launcher. This PR fixes that.

@mitchhentges
Copy link
Member

mitchhentges left a comment

Looks great, thanks for the PR!

@mitchhentges mitchhentges merged commit fec9930 into james-proxy:master Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mitchhentges

This comment has been minimized.

Copy link
Member

mitchhentges commented Jan 28, 2019

Released as v1.3.4 :)

@pimterry pimterry deleted the pimterry:add-firefox-nightly branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment