Further simplified mask_for and fixed some deprecation. #1

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@james2m
Owner
james2m commented Mar 26, 2012

Hi Martin,

I've further simplified mask_for, fixed some rdoc deprecation warnings and remove the Gemfile.lock as it's good practice to do so http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/.

J.

@martinrehfeld

Hi James,

I just stumbled upon this pull request and would definitely like to merge it in -- for some reason though it is only visible in your fork and not as a pull req listed on my original repo. Maybe you have an idea on how to fix this; otherwise I can also pull your commits manually or through the Github fork queue.

Cheers,
Martin

@james2m
Owner
james2m commented Mar 26, 2012

Hi Martin,

I think it's because I selected the range of commits I wanted to pull and there is no common ancestor. I'll update my fork from your repo, re-apply these and follow up with a new pull request.

Cheers,
James

@james2m
Owner
james2m commented Mar 26, 2012

Going to close this pull request and re-raise.

J.

@james2m james2m closed this Mar 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment