Fix to prevent rare Concurrent Modification Exceptions

hapifhir · Jul 17, 2017 · a49e009 · a49e009
1 parent f7d4296
commit a49e009
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/...-base/src/main/java/ca/uhn/fhir/jpa/interceptor/RestHookSubscriptionDstu2Interceptor.java b/...-base/src/main/java/ca/uhn/fhir/jpa/interceptor/RestHookSubscriptionDstu2Interceptor.java
@@ -83,7 +83,12 @@ public class RestHookSubscriptionDstu2Interceptor extends BaseRestHookSubscripti
 	 * @param theOperation
 	 */
 	private void checkSubscriptions(IIdType idType, String resourceType, RestOperationTypeEnum theOperation) {
-		for (Subscription subscription : myRestHookSubscriptions) {
+		//avoid a ConcurrentModificationException by copying to an array
+		for (Object object : myRestHookSubscriptions.toArray()) {
+			if (object == null) {
+				continue;
+			}
+			Subscription subscription = (Subscription) object;
 			// see if the criteria matches the created object
 			ourLog.info("Checking subscription {} for {} with criteria {}", subscription.getIdElement().getIdPart(), resourceType, subscription.getCriteria());
 
@@ -121,6 +126,8 @@ private void checkSubscriptions(IIdType idType, String resourceType, RestOperati
 		}
 	}
 
+
+
 	/**
 	 * Creates an HTTP Post for a subscription
 	 */

diff --git a/...-base/src/main/java/ca/uhn/fhir/jpa/interceptor/RestHookSubscriptionDstu3Interceptor.java b/...-base/src/main/java/ca/uhn/fhir/jpa/interceptor/RestHookSubscriptionDstu3Interceptor.java
@@ -82,7 +82,13 @@ public class RestHookSubscriptionDstu3Interceptor extends BaseRestHookSubscripti
 	 * @param theOperation
 	 */
 	private void checkSubscriptions(IIdType idType, String resourceType, RestOperationTypeEnum theOperation) {
-		for (Subscription subscription : myRestHookSubscriptions) {
+		//avoid a ConcurrentModificationException by copying to an array
+		for (Object object : myRestHookSubscriptions.toArray()) {
+		//for (Subscription subscription : myRestHookSubscriptions) {
+			if (object == null) {
+				continue;
+			}
+			Subscription subscription = (Subscription) object;
 			// see if the criteria matches the created object
 			ourLog.info("Checking subscription {} for {} with criteria {}", subscription.getIdElement().getIdPart(), resourceType, subscription.getCriteria());