Skip to content
Permalink
Browse files

Revert "Allow MINUTE precision for datetimes. Closes #604"

  • Loading branch information...
jamesagnew committed Jun 8, 2017
1 parent 401185b commit c04146a76ad6b6397f0dd23b5684059f4c69121c
@@ -285,7 +285,7 @@ protected Date parse(String theValue) throws DataFormatException {
cal.set(Calendar.DAY_OF_MONTH, parseInt(value, value.substring(8, 10), 1, actualMaximum));
precision = TemporalPrecisionEnum.DAY;
if (length > 10) {
validateLengthIsAtLeast(value, 16);
validateLengthIsAtLeast(value, 17);
validateCharAtIndexIs(value, 10, 'T'); // yyyy-mm-ddThh:mm:ss
int offsetIdx = getOffsetIndex(value);
String time;
@@ -569,29 +569,6 @@ public void testParseMonthNoDashes() throws DataFormatException {
dt.setValueAsString("201302");
}

@Test
public void testParseMinute() throws DataFormatException {
DateTimeDt dt = new DateTimeDt();
dt.setValueAsString("2013-02-03T11:22");

assertEquals("2013-02-03 11:22", myDateInstantParser.format(dt.getValue()).substring(0, 16));
assertEquals("2013-02-03T11:22", dt.getValueAsString());
assertEquals(false, dt.isTimeZoneZulu());
assertNull(dt.getTimeZone());
assertEquals(TemporalPrecisionEnum.MINUTE, dt.getPrecision());
}

@Test
public void testParseMinuteZulu() throws DataFormatException {
DateTimeDt dt = new DateTimeDt();
dt.setValueAsString("2013-02-03T11:22Z");

assertEquals("2013-02-03T11:22Z", dt.getValueAsString());
assertEquals(true, dt.isTimeZoneZulu());
assertEquals("GMT", dt.getTimeZone().getID());
assertEquals(TemporalPrecisionEnum.MINUTE, dt.getPrecision());
}

@Test
public void testParseSecond() throws DataFormatException {
DateTimeDt dt = new DateTimeDt();
@@ -605,7 +582,7 @@ public void testParseSecond() throws DataFormatException {
}

@Test
public void testParseSecondZulu() throws DataFormatException {
public void testParseSecondulu() throws DataFormatException {
DateTimeDt dt = new DateTimeDt();
dt.setValueAsString("2013-02-03T11:22:33Z");

@@ -404,7 +404,7 @@ protected Date parse(String theValue) throws DataFormatException {
cal.set(Calendar.DAY_OF_MONTH, parseInt(value, value.substring(8, 10), 1, actualMaximum));
precision = TemporalPrecisionEnum.DAY;
if (length > 10) {
validateLengthIsAtLeast(value, 16);
validateLengthIsAtLeast(value, 17);
validateCharAtIndexIs(value, 10, 'T'); // yyyy-mm-ddThh:mm:ss
int offsetIdx = getOffsetIndex(value);
String time;
@@ -1,16 +1,9 @@
package org.hl7.fhir.dstu3.model;

import ca.uhn.fhir.context.FhirContext;
import ca.uhn.fhir.parser.DataFormatException;
import ca.uhn.fhir.util.TestUtil;
import ca.uhn.fhir.validation.ValidationResult;
import org.apache.commons.lang3.time.FastDateFormat;
import org.hamcrest.Matchers;
import org.junit.AfterClass;
import org.junit.Assert;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.either;
import static org.hamcrest.Matchers.endsWith;
import static org.junit.Assert.*;

import java.text.SimpleDateFormat;
import java.time.LocalDateTime;
@@ -21,8 +14,20 @@
import java.util.Locale;
import java.util.TimeZone;

import static org.hamcrest.Matchers.*;
import static org.junit.Assert.*;
import org.apache.commons.lang3.time.FastDateFormat;
import org.hamcrest.Matchers;
import org.hl7.fhir.instance.model.api.IBaseResource;
import org.junit.AfterClass;
import org.junit.Assert;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;

import ca.uhn.fhir.context.FhirContext;
import ca.uhn.fhir.parser.DataFormatException;
import ca.uhn.fhir.parser.IParser;
import ca.uhn.fhir.util.TestUtil;
import ca.uhn.fhir.validation.ValidationResult;

public class BaseDateTimeTypeDstu3Test {
private static FhirContext ourCtx = FhirContext.forDstu3();
@@ -453,7 +458,7 @@ public void testParseInvalid() {
dt.setValueAsString("1974-12-25+10:00");
fail();
} catch (ca.uhn.fhir.parser.DataFormatException e) {
assertEquals("Invalid date/time format: \"1974-12-25+10:00\": Expected character 'T' at index 10 but found +", e.getMessage());
assertEquals("Invalid date/time format: \"1974-12-25+10:00\"", e.getMessage());
}
try {
DateTimeType dt = new DateTimeType();
@@ -535,29 +540,6 @@ public void testParseMonthNoDashes() throws DataFormatException {
dt.setValueAsString("201302");
}

@Test
public void testParseMinute() throws DataFormatException {
DateTimeType dt = new DateTimeType();
dt.setValueAsString("2013-02-03T11:22");

assertEquals("2013-02-03 11:22", myDateInstantParser.format(dt.getValue()).substring(0, 16));
assertEquals("2013-02-03T11:22", dt.getValueAsString());
assertEquals(false, dt.isTimeZoneZulu());
assertNull(dt.getTimeZone());
assertEquals(TemporalPrecisionEnum.MINUTE, dt.getPrecision());
}

@Test
public void testParseMinuteZulu() throws DataFormatException {
DateTimeType dt = new DateTimeType();
dt.setValueAsString("2013-02-03T11:22Z");

assertEquals("2013-02-03T11:22Z", dt.getValueAsString());
assertEquals(true, dt.isTimeZoneZulu());
assertEquals("GMT", dt.getTimeZone().getID());
assertEquals(TemporalPrecisionEnum.MINUTE, dt.getPrecision());
}

@Test
public void testParseSecond() throws DataFormatException {
DateTimeType dt = new DateTimeType();
@@ -571,7 +553,7 @@ public void testParseSecond() throws DataFormatException {
}

@Test
public void testParseSecondZulu() throws DataFormatException {
public void testParseSecondulu() throws DataFormatException {
DateTimeType dt = new DateTimeType();
dt.setValueAsString("2013-02-03T11:22:33Z");

@@ -343,7 +343,7 @@ protected Date parse(String theValue) throws IllegalArgumentException {
retVal = ourYearMonthDayTimeMilliFormat.parse(theValue);
}
} catch (ParseException p2) {
throw new IllegalArgumentException("Invalid date/time string (" + p2.getMessage() + "): " + theValue);
throw new IllegalArgumentException("Invalid data/time string (" + p2.getMessage() + "): " + theValue);
}
setTimeZone(theValue, hasMillis);
setPrecision(TemporalPrecisionEnum.MILLI);
@@ -357,7 +357,7 @@ protected Date parse(String theValue) throws IllegalArgumentException {
retVal = ourYearMonthDayTimeFormat.parse(theValue);
}
} catch (ParseException p2) {
throw new IllegalArgumentException("Invalid date/time string (" + p2.getMessage() + "): " + theValue);
throw new IllegalArgumentException("Invalid data/time string (" + p2.getMessage() + "): " + theValue);
}

setTimeZone(theValue, hasMillis);
@@ -372,7 +372,7 @@ protected Date parse(String theValue) throws IllegalArgumentException {
retVal = ourYearMonthDayTimeMinsFormat.parse(theValue);
}
} catch (ParseException p2) {
throw new IllegalArgumentException("Invalid date/time string (" + p2.getMessage() + "): " + theValue, p2);
throw new IllegalArgumentException("Invalid data/time string (" + p2.getMessage() + "): " + theValue, p2);
}

setTimeZone(theValue, hasMillis);

0 comments on commit c04146a

Please sign in to comment.
You can’t perform that action at this time.