Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$validate-code operation needs to be optimized for large ValueSets. #1431

Closed
dmuylwyk opened this issue Aug 19, 2019 · 2 comments
Assignees
Labels

Comments

@dmuylwyk
Copy link
Collaborator

@dmuylwyk dmuylwyk commented Aug 19, 2019

ValueSet operation $validate-code will fail for large ValueSets.

See invocation of doExpand(ValueSet theSource) in the following:

  • FhirResourceDaoValueSetDstu3.validateCode(...)
  • FhirResourceDaoValueSetR4.validateCode(...)
  • FhirResourceDaoValueSetR5.validateCode(...)

Just as we do for operation $expand, we need to leverage the terminology tables.

This should be a fairly straightforward lookup.

@dmuylwyk

This comment has been minimized.

Copy link
Collaborator Author

@dmuylwyk dmuylwyk commented Aug 27, 2019

@dmuylwyk

This comment has been minimized.

Copy link
Collaborator Author

@dmuylwyk dmuylwyk commented Aug 28, 2019

Pull request: #1455

@dmuylwyk dmuylwyk closed this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.