Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOINC filenames should be configurable. #1447

Closed
dmuylwyk opened this issue Aug 26, 2019 · 3 comments
Assignees
Labels

Comments

@dmuylwyk
Copy link
Collaborator

@dmuylwyk dmuylwyk commented Aug 26, 2019

We're going to make the filenames used for LOINC configurable by placing them in the properties file. They should default to the current names if they are not present in that file.

Currently, the LOINC uploader assumes that the files in the zip file will have specific filenames (e.g. the main concept file will be LoincTable/Loinc.csv within the zip file.) These are currently defined in constants in TerminologyLoaderSvcImpl.

These filenames occasionally change so they should be made configurable in loincupload.properties (we define this filename so we can trust it to be stable).

@dmuylwyk dmuylwyk self-assigned this Aug 26, 2019
@dmuylwyk

This comment has been minimized.

Copy link
Collaborator Author

@dmuylwyk dmuylwyk commented Aug 26, 2019

@dmuylwyk

This comment has been minimized.

Copy link
Collaborator Author

@dmuylwyk dmuylwyk commented Aug 26, 2019

Pull request: #1448

@dmuylwyk

This comment has been minimized.

Copy link
Collaborator Author

@dmuylwyk dmuylwyk commented Aug 26, 2019

These are the property keys we will use:

loinc.answerlist.file
loinc.answerlist.link.file
# This is the version identifier for the AnswerList file
loinc.answerlist.version
# This is the version identifier for uploaded ConceptMap resources
loinc.conceptmap.version
loinc.document.ontology.file
loinc.file
loinc.group.file
loinc.group.terms.file
loinc.hierarchy.file
loinc.ieee.medical.device.code.mapping.table.file
loinc.imaging.document.codes.file
loinc.parent.group.file
loinc.part.file
loinc.part.link.file
loinc.part.related.code.mapping.file
loinc.rsna.playbook.file
loinc.top2000.common.lab.results.si.file
loinc.top2000.common.lab.results.us.file
loinc.universal.lab.order.valueset.file
@dmuylwyk dmuylwyk closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.