Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant search parameters in generated includeParam #1546

Closed
jvitrifork opened this issue Oct 17, 2019 · 1 comment

Comments

@jvitrifork
Copy link
Contributor

@jvitrifork jvitrifork commented Oct 17, 2019

Looking at the tool-generated resource providers in the JPA package, it looks like there is room for refinement when looking at the search parameters generated for the includeParam. Below you'll see what is contained in eg. ca.uhn.fhir.jpa.rp.dstu3.AppointmentResourceProvider

"Appointment:actor" , "Appointment:incomingreferral" , "Appointment:location" , "Appointment:patient" , "Appointment:practitioner" , "Appointment:actor" , "Appointment:incomingreferral" , "Appointment:location" , "Appointment:patient" , "Appointment:practitioner" , "Appointment:actor" , "Appointment:incomingreferral" , "Appointment:location" , "Appointment:patient" , "Appointment:practitioner" , "Appointment:actor" , "Appointment:incomingreferral" , "Appointment:location" , "Appointment:patient" , "Appointment:practitioner" , "Appointment:actor" , "Appointment:incomingreferral" , "Appointment:location" , "Appointment:patient" , "Appointment:practitioner" , "*"

  • it looks like there is some redundancy here
@jamesagnew

This comment has been minimized.

Copy link
Owner

@jamesagnew jamesagnew commented Oct 17, 2019

Thanks for pointing this out. Looks like we had an extra for loop in the generator!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.