New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better structures "add" methods #170

Closed
jamesagnew opened this Issue Apr 30, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@jamesagnew
Owner

jamesagnew commented Apr 30, 2015

From Claude

[2015-04-29, 1:49:41 AM] Claude: I noticed another thing with the library. It might have been fixed but just pointing it out in case. The library has add methods but they don’t take arguments - e.g.:
[2015-04-29, 1:49:42 AM] Claude: codeableConcept.addCoding();
[2015-04-29, 1:49:58 AM] Claude: They are so tempting but so disappointing :)
[2015-04-29, 1:50:11 AM] Claude: I really want to given them an argument to add!
[2015-04-29, 1:50:54 AM] Claude: What I do is codeableConcept.getCoding().add(x)

@steve1medix

This comment has been minimized.

steve1medix commented May 5, 2015

+1 the adds are not chain-able. I would like to do the following:

def myPatient = new Patient().addIdentifier( new IdentifierDt('http://hl7.org/fhir/sid/us-ssn', '111-11-1111') ).addIdentifier( new IdentifierDt('http://hl7.org/fhir/v2/0203', '12345') ).addName( new HumanNameDt() )

Grails is an excellent example of fluent-ness:
http://grails.github.io/grails-doc/latest/guide/GORM.html

jamesagnew added a commit that referenced this issue May 21, 2015

Fix #170 - Better addXXX methods in structures. Also don't incorrectly
include IDs in client create requests, and add better getLink methods
to the bew Bundle resource structure.
@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented May 21, 2015

1.1-SNAPSHOT build has been pushed.

@jamesagnew jamesagnew closed this May 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment