New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAPI FHIR OSGi CORE bundle, maven pom generates dirty manifest #234

Closed
akley opened this Issue Sep 30, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@akley
Contributor

akley commented Sep 30, 2015

Hi James!

Today I found a really nasty thing, not really a bug more a ugly behaviour of maven-bundle-plugin.

Your maven-bundle-plugin configuration in the hapi-fire-osgi-core pom contains special tag to remove bundle header "Built-By" <_removeheaders>Built-By</_removeheaders>.
Keep in mind that maven-bundle-plugin already removes "Include-Resource" and "Private-Package" by default, if nothing else is configured.
Please see: https://github.com/apache/felix/blob/trunk/tools/maven-bundle-plugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java (line: 1447, getDefaultProperties method):
"properties.put( Constants.REMOVEHEADERS, Analyzer.INCLUDE_RESOURCE + ',' + Analyzer.PRIVATE_PACKAGE );"

But the defined line in your pom, as I have shown above, supress removing special bundle headers by maven-bundle-plugin. "_removeheaders" will not extend the list of removing bundle headers, it will be replaced. So the result is a dirty manifest which shows local pathes. Please check my attachment!

Resolution:
Modify removeheaders parmeter in your pom: <_removeheaders>Built-By, Include-Resource, Private-Package</_removeheaders> will replace the remove list by defined bundle headers.

Cheers
Alex

Regardless of this the bundle is working quite well so far.

dirtymanifest

@jamesagnew jamesagnew closed this in 0a5e604 Oct 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment