New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect inclusion of $ prefix on operation names in the Conformance resource #267

Closed
dionmcm opened this Issue Dec 7, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@dionmcm

dionmcm commented Dec 7, 2015

I noticed an inconsistency between HAPI server and Health Intersections FHIR server for the population of Conformance.rest.operation.name - HAPI includes the $ prefix and Health Intersections does not.

A ticket has been raised on the specification, because it isn't very clear likely resulting in this inconsistency.

I also posted a message on Zulip and got a response from Grahame Grieve (included below) that the $ is a prefix and the actual operation name does not include the $, hence it should not be included. That seems reasonable, but I've left the ticket open on the FHIR spec because the section in question http://hl7.org/fhir/conformance-definitions.html#Conformance.rest.operation.name isn't clear about this and could be better.

However this means that HAPI should not include the $ prefix in Conformance.rest.operation.name

FHIR Zulip chat

https://zulip.fhir.me/#narrow/near/793/stream/implementers/topic/conformance
implementers > conformance

Dion McMurtrie: FYI @grahame Grieve and @james Agnew, I just created http://gforge.hl7.org/gf/project/fhir/tracker/?action=TrackerItemEdit&tracker_item_id=9114 on Conformance.rest.operation.name inconsistency. The question is whether the "$" should prefix the name in this attribute - HAPI includes the "$", Health Intersections test FHIR server doesn't. Which is right?

Grahame Grieve: DIon - I think that the docuemntation is specific, and that the name does not include the $

Dion McMurtrie: Not from what I can see at http://hl7.org/fhir/conformance-definitions.html#Conformance.rest.operation.name - it says "The name of a query, which is used in the _query parameter when the query is called." and the comments are "The name here SHOULD be the same as the name in the definition, unless there is a name clash and the name cannot be used."

Dion McMurtrie: But maybe I'm not reading something into that I should be? Or perhaps there is another part of the spec which clarifies it?

Grahame Grieve: "Most Operations are a POST to a FHIR endpoint, where the name of the operations is prefixed by a "dollar sign" ('$') character"

Dion McMurtrie: OK, that works for me. I think a slightly more specific comment at http://hl7.org/fhir/conformance-definitions.html#Conformance.rest.operation.name could avoid this inconsistency, even just a link to the text you just quoted. I'll raise a bug on HAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment