New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PractitionerRole.role shouldn't be bound by an enum #320

Closed
Ricq opened this Issue Mar 24, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@Ricq

Ricq commented Mar 24, 2016

While working with HAPI-FHIR to implement an IHE MHD2 resource provider, we found that the role property of the Practitioner.practitionerRole is fixed to an enum (PractitionerRoleEnum) in the HAPI code base.

This set is a very limited set of roles, and is only as an example in the FHIR spec. An example code set shouldn't be a fixed enum. Excerpt from the FHIR description of example code set:

Instances are not expected or even encouraged to draw from the specified value set. The value set merely provides examples of the types of concepts intended to be included.

Can you update the role attribute to be a normal CodeableConceptDt instead of a BoundCodeableConceptDt?

Note: I haven't looked at other locations, but if you generate these classes from the spec automatically then there may be many more occassions where code sets are only given as examples. The fix should then probably apply to all of these locations.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 25, 2016

This makes sense, thanks for the suggestion!

I have a fix for this done- will check it in shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment