New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML parsing vulnerable to XXE #339

Closed
jimsteel opened this Issue Apr 19, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@jimsteel

jimsteel commented Apr 19, 2016

It seems like HAPI's XML input may be vulnerable to XXE attacks (https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Processing)

I'm not sure whether the use of external entities is desirable. If not, a fix like https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Prevention_Cheat_Sheet#StAX_and_XMLInputFactory might be fairly simple.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Apr 19, 2016

Hi Jim, thanks for the report! I had a look and yes, this is a vulnerability in both the XML parser as well as the Schema validator. Will commit a fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment