New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates don't populate Last-Modified or ETag HTTP response headers #374

Closed
jimsteel opened this Issue May 25, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@jimsteel

jimsteel commented May 25, 2016

A successful update (PUT) of a resource should populate the Last-Modified and ETag response headers. From

From https://www.hl7.org/fhir/http.html#update
If the interaction is successful, the server SHALL return either a 200 OK HTTP status code if the resource was updated, or a 201 Created status code if the resource was created, with a Last-Modified header, and an ETag header which contains the new versionId of the resource.

These aren't currently populated.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented May 31, 2016

Well... this turned out to be a surprisingly big change. It turns out that create/update/delete use a different code path for responses from read/search/etc. That has been cleaned up so that they both follow the same path. This is definitely an improvement.

Thanks for reporting, checking in a fix shortly!

jamesagnew added a commit that referenced this issue Jun 1, 2016

Clean up build so that JAX-RS uses the same response pipeline as the
non-JAX-RS codebase for create/update/delete responses, re #374
@jimsteel

This comment has been minimized.

jimsteel commented Jun 13, 2016

I'm seeing the ETag now, but not the Last-Modified. Is there something I need to configure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment