Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
not forwarding POST parameters when _format is provided as a URL param on _search #411
changed the title from
not forwarding parameters when _format is provided as a URL param on _search
not forwarding POST parameters when _format is provided as a URL param on _search
Jul 25, 2016
added a commit
Sep 26, 2016
I still don't really understand what the distinction is between the test case (which looks good) and my use case, but I'm seeing, for example,
giving a different result to
Fascinating. I see what you mean, and I get different results too between those command lines.. but even using those exact commands in a unit test doesn't seem to yield different results.
Are you seeing this issue on other servers than fhirtest.uhn.ca? I'm wondering if maybe the Apache reverse proxy is monkeying with the request.
Yeah, I'm seeing the same behaviour in our product not behind any proxy. We have a provider with a method annotated with
Ahhhh victory. I figured it out.
The RestfulServer does its own parsing of urlencoded data (the request URL and the POST body) because a few servers (Tomcat and Glassfish) parse using ISO-8859/1 instead of UTF-8, so we don't want to rely on their parse logic.
The issue was that some interceptors were "consuming" the request body before the server had a chance to look at it. I have a fix I'll check in as soon as the tests pass...
I don't remember all of the details of my investigation at the time.. but IIRC Tomcat and Glassfish (same underlying codebase for the HTTP stack which is why they do it the same) just used 8859-1 hard coded. I remember reproducing that issue on my Mac, where the platform default is UTF-8.
Ahh, just checked and sure enough I remember right: https://tomcat.apache.org/tomcat-6.0-doc/config/http.html (search for 8859-1)