New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.hl7.fhir.utilities.xhtml.XhtmlNode#equalsDeep incorrect (HAPI v2.0) #443

Closed
XcrigX opened this Issue Sep 9, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@XcrigX

XcrigX commented Sep 9, 2016

In org.hl7.fhir.utilities.xhtml.XhtmlNode
The equalsDeep() method contains the following:
public boolean equalsDeep(XhtmlNode other) { if (other instanceof XhtmlNode) return false; ... }

I believe the IF statement should be negated.

This causes an equalsDeep to fail for any resource containing a section like:
<text> <status value="generated"/> <div xmlns="http://www.w3.org/1999/xhtml">A human-readable rendering of the ExplanationOfBenefit</div> </text>

The ExplanationOfBenefit sample xml from the FHIR main site fails, for example.

http://hl7.org/fhir/2016Sep/explanationofbenefit-example.xml.html

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Sep 29, 2016

Owner

Thanks for reporting! Checking in a fix now.

Owner

jamesagnew commented Sep 29, 2016

Thanks for reporting! Checking in a fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment