New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request through the HAPI client sets ID of all resources to the ID of the top resource #446

Closed
FilipDomazet opened this Issue Sep 15, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@FilipDomazet
Contributor

FilipDomazet commented Sep 15, 2016

When sending an update request through the HAPI client, the ID of all resources is overwritten and set to the ID of the top level resource. This causes problems in further handling of the resources and resource references. The project uses DSTU2 structures. This problem does not occur in version 1.2.

We have narrowed down the cause to the class ca.uhn.fhir.rest.method.MethodUtil in hapi-fhir-base project. This class contains the method createUpdateInvocation(IBaseResource, String, IIdType, FhirContext). In this method there is the following line (line 219 in the file):

retVal.setForceResourceId(theId);

When this line is removed our own project worked as expected, however, some tests in the project hapi-fhir-structures-dstu3 failed.

jamesagnew added a commit that referenced this issue Sep 16, 2016

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Sep 16, 2016

Owner

Thanks for reporting! A fix has been checked in.

Owner

jamesagnew commented Sep 16, 2016

Thanks for reporting! A fix has been checked in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment