New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support prettyPrint in browser display #464

Closed
allanbrohansen opened this Issue Oct 12, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@allanbrohansen

allanbrohansen commented Oct 12, 2016

Small request :-)
We are not using prettyPrint but do support a browser friendly display (via ResponseHighlighterInterceptor).
I would like the generated html do include a "view as pretty print" option, adding a _pretty=true parameter to the url.

@allanbrohansen allanbrohansen changed the title from support prettyprint to support prettyPrint in browser display Oct 12, 2016

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Oct 12, 2016

Owner

Hi Allan,

Maybe I'm missing something obvious, but why would you want this? The ResponseHighlighterInterceptor already pretty prints by default (even if that parameter isn't found in the URL) so wouldn't this link not have any effect?

Owner

jamesagnew commented Oct 12, 2016

Hi Allan,

Maybe I'm missing something obvious, but why would you want this? The ResponseHighlighterInterceptor already pretty prints by default (even if that parameter isn't found in the URL) so wouldn't this link not have any effect?

@allanbrohansen

This comment has been minimized.

Show comment
Hide comment
@allanbrohansen

allanbrohansen Oct 13, 2016

Hi James. I do not experience a pretty print by default, so adding ?_pretty=true makes a difference.
E.g.. http://username:password@my-environment.com/Organization/OrgId?_pretty=true.
I am using HAPI 1.6. I also notice that I do not have the "Response generated in "-display that is shown on http://fhirtest.uhn.ca/baseDstu2/Patient/.

allanbrohansen commented Oct 13, 2016

Hi James. I do not experience a pretty print by default, so adding ?_pretty=true makes a difference.
E.g.. http://username:password@my-environment.com/Organization/OrgId?_pretty=true.
I am using HAPI 1.6. I also notice that I do not have the "Response generated in "-display that is shown on http://fhirtest.uhn.ca/baseDstu2/Patient/.

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Oct 18, 2016

Owner

Well I'll be.

I always thought pretty was the default in that interceptor, but you're right, it isn't. I guess I've always used it on servers where pretty was the default all over! Learn something new every day..

I see no reason why it shouldn't be the default when using the interceptor.. Pretty coloured source that's all on one line is not very useful :)

Will fix.

Owner

jamesagnew commented Oct 18, 2016

Well I'll be.

I always thought pretty was the default in that interceptor, but you're right, it isn't. I guess I've always used it on servers where pretty was the default all over! Learn something new every day..

I see no reason why it shouldn't be the default when using the interceptor.. Pretty coloured source that's all on one line is not very useful :)

Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment