Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference resource in bundle entry by UUID via fullURL does not work #544

Closed
jodue opened this issue Jan 23, 2017 · 5 comments
Closed

Reference resource in bundle entry by UUID via fullURL does not work #544

jodue opened this issue Jan 23, 2017 · 5 comments

Comments

@jodue
Copy link
Contributor

@jodue jodue commented Jan 23, 2017

I am currently trying to process a bundle which contains a DocumentReference resource that has an author which is a reference to another resource in this bundle (another entry) and the reference is done by UUID.

<DocumentReference> ... <author><reference value="urn:uuid:c7ed89ea-e167-4fab-876c-93d535cb0553" /></author> ... </DocumentReference>

and

<entry> <fullUrl value="urn:uuid:c7ed89ea-e167-4fab-876c-93d535cb0553" /> <resource> <Practitioner>...</Practitioner> </resource> ... </entry>

As far as i can see in the FHIR standard this should be correct (see example in https://www.hl7.org/FHIR/bundle.html#references) but the parser in HAPI-FHIR does not resolve the author resource properly. I had a look in the code in ParserState.stitchBundleCrossReferences which should handle this and it seems that this kind of references are currently not supported/implemented by HAPI-FHIR.

See also example bundle in the attachement.

Bundle.txt

@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented Jan 23, 2017

Thanks for reporting! This is going to be a pain to fix.. :) but I agree it should be stitching these.

jamesagnew added a commit that referenced this issue Jan 23, 2017
@jodue
Copy link
Contributor Author

@jodue jodue commented Jan 24, 2017

Great, thank you for the fast answer! If i can help (also by contributing code) i am more than willing. Just let me know.

@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented Jan 24, 2017

Hey @jodue , I actually only saw your reply after already having fixed this. The root cause was an issue I've wanted to fix for a while (IdType/IdDt parsing placeholder IDs into a prefix and a root when it should actually treat them as an opaque string) so I dove in and corrected all of that.

If you're interested in getting involved in other parts of the code base, naturally we would welcome any help you want to offer! :)

@jodue
Copy link
Contributor Author

@jodue jodue commented Jan 24, 2017

Perfect! Thanks again for fixing this so fast!

I am working on a project where we utilize the HAPI-FHIR library and since we just started we probably will find other areas where we want to fix/improve code. I already saw that at least one other person from my company (Agfa Healthcare) contributed code to this library in the past.

@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented Jan 24, 2017

Oh cool! Yeah, we've had some really cool contributions out of your company.

Glad to hear we have another team from AGFA using HAPI now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.