New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Resource.profile() and use id() instead #59

Closed
wdebeau1 opened this Issue Dec 10, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@wdebeau1
Collaborator

wdebeau1 commented Dec 10, 2014

After talking with James, the way profile tags are added for custom resources is a bit confusing, and unless you can provide the complete url to your profile, there doesn't seem to be a good way to use the custom profile tagging feature.

So, we think profile() should be removed, and the profile should be based on the id(), augmented by the server address strategy.
That is... if:
@ResourceDef(name="DiagnosticReport", id="customdiagnosticreport")
public class CustomDiagnosticReport...

and your server was at
http://myserver.zippy.com/fhir

your profile tag would end up
http://myserver.zippy.com/fhir/Profile/customdiagnosticreport

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Dec 10, 2014

I think I'd suggest leaving profile(), and doing the logic you suggest only if it's blank/not populated.
The rationale is that you might want to create a custom resource type that's based on someone else's profile that's hosted elsewhere. That way you could still say that you are implementing that resource type and have the server tag things with it, but not actually have the server export a profile.

wdebeau1 pushed a commit to wdebeau1/hapi-fhir that referenced this issue Dec 12, 2014

wdebeau1 pushed a commit to wdebeau1/hapi-fhir that referenced this issue Dec 16, 2014

wdebeau1 pushed a commit to wdebeau1/hapi-fhir that referenced this issue Dec 16, 2014

wdebeau1 pushed a commit to wdebeau1/hapi-fhir that referenced this issue Dec 16, 2014

wdebeau1 pushed a commit to wdebeau1/hapi-fhir that referenced this issue Dec 16, 2014

jamesagnew added a commit that referenced this issue Dec 17, 2014

jamesagnew added a commit that referenced this issue Dec 17, 2014

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Dec 17, 2014

Pull request merged.

@jamesagnew jamesagnew closed this Dec 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment