New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid potential short circuit during saveDeferred processing of uploaded (e.g. LOINC) terminology #1015

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@jschneid-nmdp
Contributor

jschneid-nmdp commented Jun 27, 2018

The BaseHapiTerminologySvcImpl saveDeferred method's early return when myDeferredConcepts and myConceptLinksToSaveLater are both empty has the potential to cause some value sets and concept maps to not be saved.

Prior to making the change illustrated by this PR, testing of upload-terminology for LOINC 2.64 indicated 270 deferred ValueSet resources were not saved. Some of the not-saved value sets were: LL736-0, LL999-4, loinc-document-ontology, top-2000-lab-observations-us, and loinc-universal-order-set-vs.

modify BaseHapiTerminologySvcImpl saveDeferred method to avoid short …
…circuit that could potentially prevent processing of some deferred value sets and concept maps

@jamesagnew jamesagnew merged commit 8c849b1 into jamesagnew:master Jun 27, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

jamesagnew added a commit that referenced this pull request Jun 27, 2018

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Jun 27, 2018

Owner

Looks good, thanks! This has been merged.

Owner

jamesagnew commented Jun 27, 2018

Looks good, thanks! This has been merged.

@jschneid-nmdp jschneid-nmdp deleted the jschneid-nmdp:resolve-term-upload-deferred-short-circuit branch Jun 28, 2018

@jschneid-nmdp jschneid-nmdp restored the jschneid-nmdp:resolve-term-upload-deferred-short-circuit branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment