New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerExceptions in DateRangeRaram #1047

Merged
merged 2 commits into from Nov 11, 2018

Conversation

Projects
None yet
3 participants
@hdconradi
Contributor

hdconradi commented Aug 1, 2018

There a possible NullPointerExceptions in the DateRangeParam class which can be triggered e.g. when a search query for _lastUpdated is not properly filled (examples include "", "lt", "gt").
The patch consits of two commits. The first adds adds junits tests which demonstrate the problem.
The second commit proposes a solution.

@coveralls

This comment has been minimized.

coveralls commented Aug 1, 2018

Coverage Status

Coverage increased (+0.005%) to 73.063% when pulling 7ed92e0 on hdconradi:null-pointer-in-date-range-param into cffe4c9 on jamesagnew:master.

@hdconradi hdconradi force-pushed the hdconradi:null-pointer-in-date-range-param branch from 7ed92e0 to ea5cf9f Sep 27, 2018

@hdconradi

This comment has been minimized.

Contributor

hdconradi commented Sep 27, 2018

Rebased after 3.5.0

@jamesagnew jamesagnew merged commit 023877e into jamesagnew:master Nov 11, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on null-pointer-in-date-range-param at 74.634%
Details
@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Nov 11, 2018

Thanks for the PR! Merging before 3.6.0 release.

jamesagnew added a commit that referenced this pull request Nov 11, 2018

@hdconradi hdconradi deleted the hdconradi:null-pointer-in-date-range-param branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment