New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql configs and DSTU2 security labels #110

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mojitoholic
Contributor

mojitoholic commented Feb 19, 2015

Added (commented-out) mysql configs to hapi-fhir-server-database-config.xml and the corresponding class to facilitate mysql-based deployment.

Added (commented-out) mysql configs to hapi-fhir-server-database-conf…
…ig.xml and the corresponding class to facilitate mysql-based deployment.
@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Feb 19, 2015

[Jenkins Automated Message - This is not a real comment from James] OK TO TEST?

@mojitoholic

This comment has been minimized.

Contributor

mojitoholic commented Feb 19, 2015

Yes. This is a very small change.

@mojitoholic

This comment has been minimized.

Contributor

mojitoholic commented Feb 20, 2015

My latest commit includes support for DSTU-2 style security labels for both XML and JSON parsers. I ended up adding a method to the FHIR Context to return the suitable implementation of CodingDt based on the FHIR version.
Note that I avoided modifying BaseCodingDt lest it will break other people's codes. Therefore, I only support Code, System and Display but I have added todo notes and commented-out code for supporting Version.

@mojitoholic mojitoholic changed the title from mysql configs to mysql configs and DSTU2 security labels Feb 20, 2015

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Feb 24, 2015

Ok, I'm merging this now. Nice work on it, thanks for the contribution!

I made a couple of tweaks to get it to support other attributes in CodingDt (version, active, etc.) and added a unit test, but otherwise it's going in as it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment