Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuestionnaireResponses should be able to have Items without Answers in disabled Questions #1228

Merged
merged 110 commits into from May 30, 2019

Conversation

Projects
None yet
5 participants
@mattiuus
Copy link
Contributor

commented Mar 6, 2019

Related to issue #1042

This augments our earlier pull request with Enablewhen support. Without these fixes the validation fails with answers that have items, but no answers – which should be allowed in R4.

Eeva Turkka and others added some commits Nov 2, 2018

Matti Uusitalo
Thread questionnaireResponse root element through questionnaire valid…
…ation so implementations of enablewhen may validate against the complete resource
@coveralls

This comment has been minimized.

Copy link

commented Mar 6, 2019

Coverage Status

Coverage decreased (-0.01%) to 74.924% when pulling 5e0996d on eevaturkka:enablewhen_master into 4138832 on jamesagnew:master.

@mattiuus

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

Working on the conflicts

@mattiuus

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

Merge conflicts resolved. Unfortunately rest of the code is not compiling but I can't get the master to compile either.

@mattiuus

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

I made the fixes requested in the review. Thr PR is ready for a new review.

@jamesagnew jamesagnew merged commit 772d31d into jamesagnew:master May 30, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

jamesagnew added a commit that referenced this pull request May 30, 2019

jamesagnew added a commit to hapifhir/org.hl7.fhir.core that referenced this pull request May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.