Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fetchValueSet to IValidationSupport and made it public #1255

Merged
merged 5 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@patrick-werner
Copy link
Collaborator

commented Mar 27, 2019

fixes #1254

patrick-werner added some commits Mar 27, 2019

@patrick-werner patrick-werner requested a review from jamesagnew Mar 30, 2019

@patrick-werner

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 30, 2019

this allows extended DefaultProfileValidationsupport classes to overwrite fetchValueSet which was package-private before.
All implementing classes are updated.
@jamesagnew could you please push a SnapShot to the repo after merging? Thanks!

@jamesagnew

This comment has been minimized.

Copy link
Owner

commented Apr 15, 2019

Looks good!

@jamesagnew jamesagnew merged commit 311246e into master Apr 15, 2019

1 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jamesagnew jamesagnew deleted the addFetchValueSet branch Apr 15, 2019

jamesagnew added a commit that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.