Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing not needed "super." when calling preProcessValues() #1303

Merged
merged 2 commits into from May 30, 2019

Conversation

Projects
None yet
2 participants
@basecade
Copy link
Contributor

commented May 7, 2019

preProcessValues() is not overridden in JsonParser og XmlParser so calling super.preProcessValues() doesn't make sense and it prevents inherited versions of JsonParser and XmlParser to override preProcessValues().

@jamesagnew

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

Thanks! Makes sense.

@jamesagnew jamesagnew merged commit 7863393 into jamesagnew:master May 30, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

jamesagnew added a commit that referenced this pull request May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.