Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update identifier example type #1375

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@nickrobison-usds
Copy link
Contributor

commented Jul 10, 2019

This change updates the example definition for the Identifier datatype to use a String type, rather than URI. This should address an issue that we're facing when creating profiles on top of this definition:

StructureDefinition.snapshot.element[16].example.valueUri,message=URI values cannot have whitespace

I'm sure there are other changes that I'm missing, happy to expand the PR to address them.

Thanks for the excellent work!

Correct identifier example type
Update profile example to use String type, rather than URI. This should address an issue that we're facing when creating profiles on top of this definition.

The error is: `StructureDefinition.snapshot.element[16].example.valueUri,message=URI values cannot have whitespace`
@jamesagnew

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

Hi Nick,

Thanks for the PR- merging it now.

@jamesagnew jamesagnew merged commit 8c811a6 into jamesagnew:master Aug 13, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
jamesagnew added a commit that referenced this pull request Aug 13, 2019

@nickrobison-usds nickrobison-usds deleted the nickrobison-usds:patch-2 branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.