Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-1387: Read version from resource meta when deciding whether to … #1388

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@srdo
Copy link
Contributor

commented Jul 18, 2019

…return 304 on read

Fixes #1387

I'm not sure why HAPI FHIR is looking in the resource id for versions, is this from an earlier version of FHIR?

Stig Rohde Døssing

@jamesagnew jamesagnew merged commit bb20c21 into jamesagnew:master Aug 13, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
jamesagnew added a commit that referenced this pull request Aug 13, 2019
@jamesagnew

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

Thanks for the PR, merged!

FWIW the version being a part of the ID is indeed historical (it's been like that since early DSTU1, where there was no meta section at all) but I think it's such a fundamental behaviour at this point that I'd be reluctant to remove it because there is just so much code out there depending on it.

Your approach of using both though makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.