Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Need to implement the ancestor and descendant filters for LOINC." #1505

Conversation

dmuylwyk
Copy link
Collaborator

Closes #1454

This also includes changes to make sure we call the updateEntity(...) method on the correct DAO type when processing inside a transaction.

@dmuylwyk
Copy link
Collaborator Author

Moving implementation of ancestor filter with IN operator for LOINC to #1512.

@dmuylwyk dmuylwyk marked this pull request as ready for review September 26, 2019 15:43
@dmuylwyk
Copy link
Collaborator Author

@jamesagnew, please review. Thanks!

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@663431f). Click here to learn what that means.
The diff coverage is 81.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1505   +/-   ##
=========================================
  Coverage          ?   72.23%           
  Complexity        ?    12320           
=========================================
  Files             ?      909           
  Lines             ?    52779           
  Branches          ?     8794           
=========================================
  Hits              ?    38124           
  Misses            ?    11226           
  Partials          ?     3429
Impacted Files Coverage Δ Complexity Δ
...pa/dao/dstu3/FhirResourceDaoSubscriptionDstu3.java 61.29% <ø> (ø) 16 <0> (?)
...fhir/jpa/dao/r5/FhirResourceDaoSubscriptionR5.java 61.66% <ø> (ø) 13 <0> (?)
.../jpa/dao/dstu3/FhirResourceDaoCodeSystemDstu3.java 68.29% <ø> (ø) 18 <0> (?)
...n/fhir/jpa/dao/r5/FhirResourceDaoConceptMapR5.java 1.75% <ø> (ø) 1 <0> (?)
...fhir/jpa/dao/r4/FhirResourceDaoSubscriptionR4.java 66.66% <ø> (ø) 15 <0> (?)
...n/fhir/jpa/dao/r4/FhirResourceDaoCodeSystemR4.java 72.5% <ø> (ø) 20 <0> (?)
...fhir/jpa/dao/FhirResourceDaoSubscriptionDstu2.java 62.22% <ø> (ø) 9 <0> (?)
...n/fhir/jpa/dao/r4/FhirResourceDaoConceptMapR4.java 96.49% <ø> (ø) 14 <0> (?)
.../jpa/dao/dstu3/FhirResourceDaoConceptMapDstu3.java 53.44% <ø> (ø) 7 <0> (?)
...term/loinc/LoincPartRelatedCodeMappingHandler.java 76.36% <ø> (ø) 5 <0> (?)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663431f...ac9c10a. Read the comment docs.

Copy link
Collaborator

@jamesagnew jamesagnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@dmuylwyk dmuylwyk merged commit 1b2892f into master Sep 30, 2019
@dmuylwyk dmuylwyk deleted the 1454-need-to-implement-the-ancestor-and-descendant-filters-for-loinc branch September 30, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to implement the ancestor and descendant filters for LOINC.
2 participants